From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BA5D1E32D5 for ; Tue, 13 May 2025 05:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747113013; cv=none; b=mImscQ2n4gZrrZ4Jn2xupQSqXlb2mFpdnLAYq7KzD5UrAF3xdCyXwlj3+W5xUF+ECz4baQzZeaI23cq+BpyB0V335b4ayJjuQC/WqvA86PgT9pUBeoOuQvyYuFAt6/oYvsYfnn0vQdnrlHk23AcOCczZId+Oa27tEbc0RK3Xnu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747113013; c=relaxed/simple; bh=cxqjrBx3kTpOHbacDXp/Fe0LkjauDwSUf53IzM3RIHM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CJhrq+VAE+j4DsJ6pe4XFOoNuzWHqDZgpOPyfzpsuxO+V5koaw7MK4PXWpjBU/1KPVkomAAgTN5f1uhgKWZTrzsVOtIkNaBYxFU9vEIJMQZXGuFH8EHa8heVPqAIRBoHc0gXV23KTkVyvKe84spScDwmTXoMsLZzA41vPbF9aaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ksygQgw1; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ksygQgw1" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-b0db0b6a677so4663710a12.2 for ; Mon, 12 May 2025 22:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747113010; x=1747717810; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=81hnT5JYAGOLBlSsNMic7sDzKs20VH/V/TIv7YvaGSs=; b=ksygQgw1+2CEWLR/9hyvr9MEND03eeP5drRyK6cN0tk5ciG5MwJ9RU52hp1h+lCllW jhQ2c65wQa20sTroWLD6y0YhdvO2m0IkHKX0VJbL6T6A0w6p8sV47F4PHWRcO78BNBrw KHxrs6FjToatxWxhLgiluitqj4ExQo8hzpCcyAG0o7WaWFh1pGkITKAdYvIV2iX+BGhb 2oGxtjA4KLDe3jwD05vED9s1AR8Yg9YFfRcqQZPhehzpcHNDPQNTJQi5Snw+1hJjgXYH oAqUduZYE5D1/ZqMgqIxPSV5ZCVC7FZeDUIkU7P9zyqq0rms9/210rzFf7TjlFR70LaW DOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747113010; x=1747717810; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=81hnT5JYAGOLBlSsNMic7sDzKs20VH/V/TIv7YvaGSs=; b=Zd/nZUfxPBR+yqV5RfMNFBgvylxxtRBk42P4etsdwRoT+9XaPBl85X+sjFc6UWvFd4 oRj+IGoMclaYSlXmxPBnFBIzBMt/4VTCAsUkWzoj4X6JfFBQkEvBh+//ccnmNBggaBB2 TOsfkYO4qAEfWAsRRgfdtcXf7tdxkdVLGjvPdSm7nZ0rv8QpToYp5CfEidNqOuNH/gXb 2cBI2Jyu+au3S+YIKX7FxVDXVC7dxbRz0nhGn51U6QQY0d9j7amC9hMifmdBUUycCD54 3dPIW2UqImpQnjTrQ971h69RuizEMg4JEW3mc1WuF18bU3hB/Zb1ktq3eUfukuEuHr3H X+9g== X-Forwarded-Encrypted: i=1; AJvYcCWJYlq0RA/rFO8l3XwATmp6/SzWU5toHvuwsgZgxtej3Pp2W3jYrw9LB/6d88c6n5YqZu6N2jQeSxZY6l8=@vger.kernel.org X-Gm-Message-State: AOJu0YzG6mXAlVW8zTxJHANDDkkmpG++c7jSvblWsUsxDLtwYbl9TeC7 hgiwwY0EmGzQlDX5pb9Xx4oyWWgXL61uTOTumeJamrGKLLdFqeX53RHGE4x74A== X-Gm-Gg: ASbGncsWnYGI42YXyrHdFX3XCj++SBc5dX9ZIo4Z2i9MrhgJ/JcQG5Dt9QxKLbTYxjJ eJUK1awccZDLcXRu2ci5sDyjeeJFgl0zXJxI3M69Ktm2VasHftDh6xtLYzYGe7rcfIdVIaggquS 4GbotHxf0ayQR073yn+HF7mjCxVKCM7MlMylbjvHrC56CLi3MTjKZRjI9FMOshp7/nxC/qgPwO7 enn8PUzM63NUt4yIDJJc22iR1RabLEGTKtl2bATd0jYpvlhCfeen1gIU+n4Ts+S5OtRDKxf+R4Q ZZyJYr0KyBycPaFWwusOx9lHj7iaksHYsGQCr9nbxF/Xba5rnARh7d/sZAlzMv4ki+UVJWcNmOA ZYhYXjYLWiG8Vt9Tjzqsi X-Google-Smtp-Source: AGHT+IGfy5kPpmg1u05cDB23GMn6/iiBBg2PQjgjfT2slhmZBcXNsZ9nNvlTSHiycu8Z5JpPXl9tnw== X-Received: by 2002:a17:903:3bc7:b0:22f:a5ff:ec67 with SMTP id d9443c01a7336-22fc8b3399cmr209564955ad.17.1747113010228; Mon, 12 May 2025 22:10:10 -0700 (PDT) Received: from ?IPV6:2600:1700:4570:89a0:d077:eefe:6c8:eb65? ([2600:1700:4570:89a0:d077:eefe:6c8:eb65]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc7549200sm71543555ad.10.2025.05.12.22.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 22:10:09 -0700 (PDT) Message-ID: Date: Mon, 12 May 2025 22:10:07 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: connector: extend ports property to model power connections To: "Rob Herring (Arm)" Cc: Len Brown , Kyle Tso , linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Krzysztof Kozlowski , Greg Kroah-Hartman , Conor Dooley , Heikki Krogerus , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , devicetree@vger.kernel.org, Sebastian Reichel , Badhri Jagan Sridharan , Pavel Machek References: <20250507-batt_ops-v2-0-8d06130bffe6@google.com> <20250507-batt_ops-v2-1-8d06130bffe6@google.com> <174667008518.3134866.16860556665392127379.robh@kernel.org> From: Amit Sunil Dhamne Content-Language: en-US In-Reply-To: <174667008518.3134866.16860556665392127379.robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Rob, On 5/7/25 7:08 PM, Rob Herring (Arm) wrote: > On Wed, 07 May 2025 18:00:22 -0700, Amit Sunil Dhamne wrote: >> Extend ports property to model power lines going between connector to >> charger or battery/batteries. As an example, connector VBUS can supply >> power in & out of the battery for a DRP. >> >> Additionally, add ports property to maxim,max33359 controller example. >> >> Signed-off-by: Amit Sunil Dhamne >> --- >> .../bindings/connector/usb-connector.yaml | 20 +++++++++++------ >> .../devicetree/bindings/usb/maxim,max33359.yaml | 25 ++++++++++++++++++++++ >> 2 files changed, 38 insertions(+), 7 deletions(-) >> > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: I ran this and didn't see any errors on my side. > dtschema/dtc warnings/errors: > > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250507-batt_ops-v2-1-8d06130bffe6@google.com Even the build logs don't show any error log. > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. My patchset is based on v6.14-rc6 and I tested it on that. > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I did all of the above but make dt_binding_check still passes. (.venv) amitsd@amitsd-gti:~/linaro-p6-image/src/linux$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/connector/usb-connector.yaml   SCHEMA  Documentation/devicetree/bindings/processed-schema.json /usr/local/google/home/amitsd/linaro-p6-image/src/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition ^ This is not newly introduced jfyi.   CHKDT   ./Documentation/devicetree/bindings   LINT    ./Documentation/devicetree/bindings   DTEX    Documentation/devicetree/bindings/connector/usb-connector.example.dts   DTC [C] Documentation/devicetree/bindings/connector/usb-connector.example.dtb (.venv) amitsd@amitsd-gti:~/linaro-p6-image/src/linux$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/maxim,max33359.yaml   CHKDT   ./Documentation/devicetree/bindings   LINT    ./Documentation/devicetree/bindings   DTEX    Documentation/devicetree/bindings/usb/maxim,max33359.example.dts   DTC [C] Documentation/devicetree/bindings/usb/maxim,max33359.example.dtb Please can you advise on what I may be missing? Thanks, Amit