From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606AbdJXHaC (ORCPT ); Tue, 24 Oct 2017 03:30:02 -0400 Received: from mga05.intel.com ([192.55.52.43]:29072 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdJXHaB (ORCPT ); Tue, 24 Oct 2017 03:30:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,426,1503385200"; d="scan'208";a="913066048" Subject: Re: [PATCH v5 2/6] perf record: Get the first sample time and last sample time To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1508542074-29483-1-git-send-email-yao.jin@linux.intel.com> <1508542074-29483-3-git-send-email-yao.jin@linux.intel.com> <20171023150436.GA10746@krava> <818cd5bf-fd40-444e-4f4d-c9e25cf90b51@linux.intel.com> <20171024071659.GB27972@krava> From: "Jin, Yao" Message-ID: Date: Tue, 24 Oct 2017 15:29:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171024071659.GB27972@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2017 3:16 PM, Jiri Olsa wrote: > On Tue, Oct 24, 2017 at 10:03:05AM +0800, Jin, Yao wrote: > > SNIP > >>> hum, could you still unset the sample if there's no time given? >>> and keep the speed in this case.. >>> >>> jirka >>> >> >> Hi Jiri, >> >> I check this question again. The '--time' option is for perf report but not >> for perf record. >> >> For perf record, we have to always walk on all samples to get the time of >> first sample and the time of last sample whatever buildid_all is enabled or >> not enabled. So 'rec->tool.sample = NULL' is removed. >> >> Sorry, the previous mail was replied at midnight, I was drowsy. :( >> >> If my answer is correct, I will not send v6. If my understanding is still >> not correct, please let me know. > > right, I did not realize we store this unconditionaly.. then yes, it's ok > > I think I've already acked this, anyway for the patchset: > > Acked-by: Jiri Olsa > > thanks, > jirka > Hi Jiri, Thanks a lot for your review comments and your helps! Thanks Jin Yao