From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A79440F8F6 for ; Mon, 15 Jun 2026 16:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781542130; cv=none; b=T5n+v2u5DuhBUiCiR83w+pUVm0oy48hLIqaYDQ/I0IMjdebQ6qqQ1B9lyDszxoqr9ZJ+AAKvVs4Xkm5mihMtPJYoUNXASO4k6fHAen2j9UJ/JWp6efrQ3cqkxMg5Hzt5Fp24bgimKqMAsIaufTDG0OKfZuigKr3pKUpr8u+vWV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781542130; c=relaxed/simple; bh=+H7/xJ0u8V7rPds7nxD25fdyLiLvfaBeodi7R2CCUic=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QnZFHIWcfNxdiAB1SNelfuFT/50n2XgH8+45sFGFyfgLG55QR7+RPfJikqKfixXYGYjQe9d5Srhmuzd8uLBSql0pELRQ2Agr7oKd9N/coIRp9KwRTIF62ozX4rV7SvJF7QjF+idoSskRvpyou7lOd7xx16ZaddAqLHENVZAnIE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dL70VqwJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cjTJsPVN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dL70VqwJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cjTJsPVN" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FFhLaB347078 for ; Mon, 15 Jun 2026 16:48:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WIMuXijjjJTR3EDSM7uSnEsn4hZwcVL3x3B6MRh+Xg0=; b=dL70VqwJXdUke43b ydmmbkPkFqYanETuthFSOiaCR+Q1ddqw2hmqomhOpdadgiZd3bPcMFJz7R1xUqoG XUesiJ22mdc49yfrOJCYXF8RmehMcMzOQy0OOwae+didMfTWfXht/zc6zixmQB8J CeyEEOgyrZfScyt4skBDnoxWXujKBa7B2il5LXppIM7PyUQQwQx1aeK5uA7Q3Ca5 gxh1I2EaTo7IMPSDN+aSmUPh6KO9gwYBWg4WjKCegPSS0D2WwlZbYEQTNiD1ZhUW o/SCteqc+99i2Qhorf3rYplnRUXpNMrWmqMDibCaGczjAfYXePQ+IEYDInRDfwS7 Fc97XA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetjsvxf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 16:48:48 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8ce9ddfa7ccso8664526d6.0 for ; Mon, 15 Jun 2026 09:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781542127; x=1782146927; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WIMuXijjjJTR3EDSM7uSnEsn4hZwcVL3x3B6MRh+Xg0=; b=cjTJsPVNsY7QSp7bnL39pgREtMSwvhyEh1+TiaoYGiI87R3d97IFF7oXqIFegB6Wec D6NuzJOLCXdCUPB5kMQg1hA8VOhiXVjCOnhkGySWZj5AOcDEUUi+HZD0NfIS6dz3EeEa ZV16LkoVhvsvjmHzueC6i5hf1DvQCC2p+AfElR8hJJ80X5KfSQC3CE+0y6ZObMSUJJhZ ARYw+kLtqRiX3dYy80bz8lyouzkLnUZtL8QmeQu0ftU+CTErcIfrkf9b727WqevNe65A rwmbua5S2VWkl4InjmmgeR5ZIVsRHzTfWPRTxYDcUji0YNc3BBI/DLGhGmGB5ESHuZtY W7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781542127; x=1782146927; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WIMuXijjjJTR3EDSM7uSnEsn4hZwcVL3x3B6MRh+Xg0=; b=s6SOWYGbSh9gMZgczqQD5J/RTATmVi8w/pop0kzwdbYe+uTdoXITjZmQ5fk2Rxl0FL eSwfN7Rf3/+lwqmPDOCv2OAPMZPKkbMod8XqzzaqlcMrnkfBFYrTx55/etsdtvkmpH44 Ta4QDTyjNObgVYIbxMVf7wrkb2KqGlKL+1KtzgP4zlMancB5QC+V6YJLJcvuMuEt4O+R +yPdAz3x4P4IRiCrx+fJMqSnFW/eZQ27LsKJcWrtIDZlu18o05Wi3LOJFcHTpt31odIF Wb7x2h7ADyiiuyC2jX54R7+XsknPDMQFGmg86+cca89Dwbga4HaHdvrkEE3hY3tYPiiR gy5Q== X-Forwarded-Encrypted: i=1; AFNElJ+7uDDUB5Jzll2cz8j2N6p61b+va4JFb0jOE0XBe6WGkgpcHavxVh2TA3LqXkRk4mgL16dubpQIKQjYe/g=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6gompQcKA8voPetHTSJ34ke7IQx2FumqWu8E7QkLu9U0Lw4Oy DBRcK8nTI5Dq1Ida8n2Mz8vNlVr+v3Yac5DCkSISDvS9AUjq/34pjK/7fX1LzTQHbtkgswtMpWn lo/Kjnr8oDCV+g1NBiZ7P5eLrrn7fnuVPYWQoFsZFsXLLl9yCVk6o6YWeaLebFPCILZw= X-Gm-Gg: Acq92OGBkNXFuPDLUuwaw6t9Adv/fcyHPJ9tgV99gnY6Vnc4NcUl9iBR43PxV8LMgxM vut8YktRNBPKCONY+k88uynAOijHA//MrCYLa9XAVyDfOvzuQmYnr2V0ys0q8TiS/pNIKqowefY 0cuuoPKCwB0bw58eHC/lKczn2C3AzRo1at9iL4svA1U2MrLo8eytbEN8s+YX23lcTY9DGSdvxqG uItkexiW34QLVkKJEfX0fFbRIpzl6PdWmbNw9z3f9HHMzu+ZNDmpEyNFmISuluQ5wHkOm2KdmtX FImZL10OIkXn6wfUYGt9Tmn6hg3bpPMVKAj4oxKfwiCz3OsQS3fLUocxaCt3RraKkjb5Vh6iA99 QDfh3rFmf0FVnrQogVqlFfrd7opvDQVVFCJp5x5atMvq5Dw== X-Received: by 2002:ad4:5ba9:0:b0:89c:5fbe:cc5b with SMTP id 6a1803df08f44-8d32869209fmr152792406d6.0.1781542127349; Mon, 15 Jun 2026 09:48:47 -0700 (PDT) X-Received: by 2002:ad4:5ba9:0:b0:89c:5fbe:cc5b with SMTP id 6a1803df08f44-8d32869209fmr152791996d6.0.1781542126730; Mon, 15 Jun 2026 09:48:46 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3995c066007sm783581fa.18.2026.06.15.09.48.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 09:48:45 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 18:48:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] arm64: dts: qcom: Add header file for ADC5 Gen3 channel macros To: Neil Armstrong , Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260430-adc5_gen3_dt-v1-0-ab2bb40fd490@oss.qualcomm.com> <20260430-adc5_gen3_dt-v1-1-ab2bb40fd490@oss.qualcomm.com> <60170148-2fef-4282-ad68-f784e4fdfe23@oss.qualcomm.com> <831ed020-4a1f-46af-95c6-38ef1f875fd1@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <831ed020-4a1f-46af-95c6-38ef1f875fd1@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE3NyBTYWx0ZWRfX3leUwtrXSxMY Z+lP5bPK808k+W48nDFLpwDi/WYNsljFl8DMIHQ+6eqb9i+GqHtrod/BZ23cEPFG0xW3gPMJEcC WXPxlNYdoku9xv1wONGwX478ptmPAVwRHU4xbmoaNLB67LLw8pQc6N8UTPkS1Ss03nEhrBlI4HG J+267E5frG1Ec/yNa4yYtz73JTGS+tdNYbtgIJegBglzBuOpl+gV+UgvtyilTbCpgWhDI7wVhEh wzkdUGXCOxKGqCSLMycBXdEP+F1iMPWQOSXftNFVxH9+RvDd0SFrUgkqP2ZayrlYXVcNdHeldET W0uk3X9SA7zruhQrXaBMUpdQcJPeq5ot2PrMwwDywtmm6C/1oZKOQhYMCpX/88e/DJCiqAbyYqF Q1NF5hFg9P+2cJ+ZBNeG0zU4D0YzbeeZibZvOrpHhqdXbzujIVrYmTFr2G21WTVW+3Z7fbQ009g djHirupEkUwMkMziVhQ== X-Proofpoint-ORIG-GUID: gVKomjv6vfuG62AF4l7N4Mr5VsaCURI_ X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE3NyBTYWx0ZWRfX/SAnFxpO9CPC MrIVgjnXzYDKdop7mrlUyym6iuIiAd64KFe0AvRxWzSVENckoTNDL7rmjSHeWWV+vchuueWjyiU IB6nWbpK838oqpQcrkGNy6tQQZkfqY0= X-Authority-Analysis: v=2.4 cv=HttG3UTS c=1 sm=1 tr=0 ts=6a302cf0 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=9RCi9ZdM10RZw5nSpo0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: gVKomjv6vfuG62AF4l7N4Mr5VsaCURI_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150177 On 6/15/26 6:39 PM, Neil Armstrong wrote: > Hi, > > On 6/15/26 17:55, Konrad Dybcio wrote: >> On 4/30/26 10:58 AM, Jishnu Prakash wrote: >>> Add macro definitions for virtual channels (combination of ADC channel >>> number and PMIC SID number), to be used in devicetree by clients of ADC5 >>> GEN3 device and in the "reg" property of ADC channels. >>> >>> Signed-off-by: Jishnu Prakash >>> --- >> >> Reviewed-by: Konrad Dybcio > > And what happens with my patch [1] ? > > I had zero feedback so far > > [1] https://lore.kernel.org/all/20260504-topic-sm8x50-adc5-gen3-v2-1-5cc04d6ecda0@linaro.org/ I think this approach (single generic header) is better. The existing ADC7 bindings which your series draws inspiration from come with a ton of boilerplate. There are some non-trivial mappings in there though, e.g.: +#define PM8550B_ADC5_GEN3_AMUX4_GPIO12_100K_PU(sid) ((sid) << 8 | ADC5_GEN3_AMUX4_GPIO_100K_PU) but these would presumably be deducible from downstream Konrad