From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbdEBD5G (ORCPT ); Mon, 1 May 2017 23:57:06 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:52943 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdEBD4M (ORCPT ); Mon, 1 May 2017 23:56:12 -0400 Subject: Re: [PATCH 1/3] ti-soc-thermal: Use devm_kcalloc() in ti_bandgap_build() To: SF Markus Elfring , , , Eduardo Valentin , Zhang Rui References: <071d2e92-0bcc-5ccc-ad28-b05a72538d6b@users.sourceforge.net> CC: LKML , From: Keerthy Message-ID: Date: Tue, 2 May 2017 09:25:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <071d2e92-0bcc-5ccc-ad28-b05a72538d6b@users.sourceforge.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 26 April 2017 09:04 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 16:45:25 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". Reviewed-by: Keerthy > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > index ba9c302454fb..f19cb7612a65 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > @@ -1224,8 +1224,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev) > bgp->conf = of_id->data; > > /* register shadow for context save and restore */ > - bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) * > - bgp->conf->sensor_count, GFP_KERNEL); > + bgp->regval = devm_kcalloc(&pdev->dev, bgp->conf->sensor_count, > + sizeof(*bgp->regval), GFP_KERNEL); > if (!bgp->regval) { > dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n"); > return ERR_PTR(-ENOMEM); >