From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA6BC48BE6 for ; Wed, 16 Jun 2021 13:24:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C5F66115C for ; Wed, 16 Jun 2021 13:24:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233235AbhFPN02 (ORCPT ); Wed, 16 Jun 2021 09:26:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51633 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231256AbhFPN0W (ORCPT ); Wed, 16 Jun 2021 09:26:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623849856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6tLWFqQWEsz56Ko5PZv18XXeVsybxvSI9R/PpDg/CYY=; b=BMTDSX7gYmQVp59K8GN7MSFBR5j23p128JFMME9dsLqU7J5vXj+foTzERArWZuHhVqIssg YFYap/n0RxoX3u550w1W/Rr+NY8wlTHiSkNGB1XeVo5ZSmKRMxssehvdg734XoEPPUzeJx 0W79OhBYjxs9OEkl0ENZRDra1in/Jw8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-Gq1SvJnyNYykSwYq3kOHrg-1; Wed, 16 Jun 2021 09:24:14 -0400 X-MC-Unique: Gq1SvJnyNYykSwYq3kOHrg-1 Received: by mail-ej1-f69.google.com with SMTP id mh17-20020a170906eb91b0290477da799023so262091ejb.1 for ; Wed, 16 Jun 2021 06:24:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6tLWFqQWEsz56Ko5PZv18XXeVsybxvSI9R/PpDg/CYY=; b=jp9nPU6U2lJHcVudLL6eK9BOlGc20McV/5fpugWS2BbPlMNNXa8YWmh3KKKeBGJSnM LfTlwVxLMjL/xqVJ74Otu3Tqe4DjAqkCf+UpkDHwWJa8EIM/kkx8b2SH3BB7QiohPfDp 28Ywe6sE8883qZQ9202auLhdt/rBihT0vz8TyFCm02ZMx8lyPhF6LaJ2WbhOGPLRPbEk egH56UpF0cQo3s2Ad/GnhRwFQr8mJJNihAT8RvrfT25paz5bavbhiv4chOtnG3G+Q6Tc 1TZheQ/u5vp9lxTxMFC+4DCxpqcmrzvLrxcAXteorPK6awscMCRB9oGPL8UmKu4XmDwj aOfw== X-Gm-Message-State: AOAM530tXNveyhsDU43pHWG1LP+h5HgJJAx6BPicWKyBAw2d/ThNC1rr KKvF9MHcGQybkCcF8aupkZ3bTo7VOKdva6SDAKbvbCfSySo7BXTHGpLcETTMIBcEawr+OlXSmgG vYlCmlDn6iUkMGBfGnFc9f4Fd X-Received: by 2002:aa7:cf0f:: with SMTP id a15mr4138446edy.313.1623849853476; Wed, 16 Jun 2021 06:24:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNlF2rQXtcidlADi5H32n7IyqgG9rDrZlrCXZqQXkNq/nK4wUcA6Bg8JuT7PnyUUx+ExFJKA== X-Received: by 2002:aa7:cf0f:: with SMTP id a15mr4138397edy.313.1623849853297; Wed, 16 Jun 2021 06:24:13 -0700 (PDT) Received: from x1.bristot.me (host-79-23-205-114.retail.telecomitalia.it. [79.23.205.114]) by smtp.gmail.com with ESMTPSA id b25sm1846160edv.9.2021.06.16.06.24.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 06:24:12 -0700 (PDT) Subject: Re: [PATCH v2 7/7] sched: Change task_struct::state To: Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman Cc: Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , Stephen Rothwell , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20210611082810.970791107@infradead.org> <20210611082838.550736351@infradead.org> From: Daniel Bristot de Oliveira Message-ID: Date: Wed, 16 Jun 2021 15:24:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210611082838.550736351@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/11/21 10:28 AM, Peter Zijlstra wrote: > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -348,10 +348,10 @@ static void task_non_contending(struct t > if ((zerolag_time < 0) || hrtimer_active(&dl_se->inactive_timer)) { > if (dl_task(p)) > sub_running_bw(dl_se, dl_rq); > - if (!dl_task(p) || p->state == TASK_DEAD) { > + if (!dl_task(p) || READ_ONCE(p->__state) == TASK_DEAD) { > struct dl_bw *dl_b = dl_bw_of(task_cpu(p)); > > - if (p->state == TASK_DEAD) > + if (READ_ONCE(p->__state) == TASK_DEAD) > sub_rq_bw(&p->dl, &rq->dl); > raw_spin_lock(&dl_b->lock); > __dl_sub(dl_b, p->dl.dl_bw, dl_bw_cpus(task_cpu(p))); > @@ -1355,10 +1355,10 @@ static enum hrtimer_restart inactive_tas > sched_clock_tick(); > update_rq_clock(rq); > > - if (!dl_task(p) || p->state == TASK_DEAD) { > + if (!dl_task(p) || READ_ONCE(p->__state) == TASK_DEAD) { > struct dl_bw *dl_b = dl_bw_of(task_cpu(p)); > > - if (p->state == TASK_DEAD && dl_se->dl_non_contending) { > + if (READ_ONCE(p->__state) == TASK_DEAD && dl_se->dl_non_contending) { > sub_running_bw(&p->dl, dl_rq_of_se(&p->dl)); > sub_rq_bw(&p->dl, dl_rq_of_se(&p->dl)); > dl_se->dl_non_contending = 0; > @@ -1722,7 +1722,7 @@ static void migrate_task_rq_dl(struct ta > { > struct rq *rq; > > - if (p->state != TASK_WAKING) > + if (READ_ONCE(p->__state) != TASK_WAKING) > return; > > rq = task_rq(p); Reviewed-by: Daniel Bristot de Oliveira Feel free to add it to the other patches as well. Thanks! -- Daniel