From: Eddie James <eajames@linux.ibm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org
Cc: linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
andrew@aj.id.au, joel@jms.id.au,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
arnd@arndb.de, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 2/4] doc: Add Atmel AT30TSE serial eeprom
Date: Tue, 21 Mar 2023 10:46:42 -0500 [thread overview]
Message-ID: <baf7ad36-0410-3063-7960-8dd7040fb8fd@linux.ibm.com> (raw)
In-Reply-To: <6d4cf513-0787-6b39-8d38-30484be7ddff@linaro.org>
On 3/21/23 10:19, Krzysztof Kozlowski wrote:
> On 21/03/2023 16:16, Eddie James wrote:
>> The AT30TSE is compatible with the JEDEC EE1004 standard. Document it
>> as a trivial I2C device.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
Oops, sorry, will fix.
>
>> ---
>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 6f482a254a1d..43e26c73a95f 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -47,6 +47,8 @@ properties:
>> - ams,iaq-core
>> # i2c serial eeprom (24cxx)
>> - at,24c08
>> + # i2c serial eeprom (EE1004 standard)
> AT30TSE?
>
>> + - atmel,at30tse
> Microchip does not find anything on AT30TSE. Are you sure this is the
> model name?
Yes:
https://www.microchip.com/content/dam/mchp/documents/OTH/ProductDocuments/DataSheets/Atmel-8868-DTS-AT30TSE004A-Datasheet.pdf
Maybe it's actually an 8868? Or should I include the 004A as well?
Thanks,
Eddie
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-21 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 15:16 [PATCH v2 0/4] eeprom: ee1004: Enable devices on multiple busses Eddie James
2023-03-21 15:16 ` [PATCH v2 1/4] " Eddie James
2023-03-21 15:39 ` Rob Herring
2023-03-21 15:45 ` Eddie James
2023-03-21 15:16 ` [PATCH v2 2/4] doc: Add Atmel AT30TSE serial eeprom Eddie James
2023-03-21 15:19 ` Krzysztof Kozlowski
2023-03-21 15:46 ` Eddie James [this message]
2023-03-21 15:55 ` Eddie James
2023-03-27 15:18 ` Rob Herring
2023-03-27 19:01 ` Eddie James
2023-03-21 15:16 ` [PATCH v2 3/4] eeprom: ee1004: Add devicetree binding Eddie James
2023-03-21 15:20 ` Krzysztof Kozlowski
2023-03-21 15:16 ` [PATCH v2 4/4] ARM: dts: aspeed: bonnell: Add DIMM SPD Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf7ad36-0410-3063-7960-8dd7040fb8fd@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®