From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757804AbdCUQU7 (ORCPT ); Tue, 21 Mar 2017 12:20:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756993AbdCUQUX (ORCPT ); Tue, 21 Mar 2017 12:20:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78A0964DB2 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 78A0964DB2 Subject: Re: [PATCH v2 2/3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1490069935-6232-1-git-send-email-wanpeng.li@hotmail.com> <1490069935-6232-2-git-send-email-wanpeng.li@hotmail.com> Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li From: Paolo Bonzini Message-ID: Date: Tue, 21 Mar 2017 17:19:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490069935-6232-2-git-send-email-wanpeng.li@hotmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 21 Mar 2017 16:19:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/2017 05:18, Wanpeng Li wrote: > - if (!cpu_has_vmx_vpid()) > + if (!cpu_has_vmx_vpid() || > + !(cpu_has_vmx_invvpid())) Too many parentheses and a useless line break. Paolo > enable_vpid = 0;