From: Juergen Gross <jgross@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] xen: avoid crash in disable_hotplug_cpu
Date: Fri, 7 Sep 2018 11:50:08 +0200 [thread overview]
Message-ID: <baf89177-9fcc-dda4-fefd-57537018c94e@suse.com> (raw)
In-Reply-To: <20180907112451.442b46fe.olaf@aepfle.de>
On 07/09/18 11:24, Olaf Hering wrote:
> Am Fri, 7 Sep 2018 09:48:28 +0200
> schrieb Juergen Gross <jgross@suse.com>:
>
>> On 07/09/18 08:30, Olaf Hering wrote:
>>> + if (cpu_online(cpu))
>>> + return;
>>> if (cpu_present(cpu))
>>> xen_arch_unregister_cpu(cpu);
>
>> Could you merge the two if conditions?
>> if (!cpu_online(cpu) && cpu_present(cpu))
>> xen_arch_unregister_cpu(cpu);
>
> Is that any different, beside being wrong, from what the patch actually does?
No. Just a matter of style.
> It would still clear the present bit later on.
This should be part of the if clause, of course.
Juergen
next prev parent reply other threads:[~2018-09-07 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 6:30 Olaf Hering
2018-09-07 7:48 ` Juergen Gross
2018-09-07 9:24 ` Olaf Hering
2018-09-07 9:50 ` Juergen Gross [this message]
2018-09-07 13:33 ` Boris Ostrovsky
2018-09-07 13:39 ` Olaf Hering
2018-09-11 11:25 ` Juergen Gross
2018-09-11 14:29 ` Boris Ostrovsky
2018-09-11 14:29 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf89177-9fcc-dda4-fefd-57537018c94e@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®