mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH wq/for-7.5 v4 2/2] workqueue: Keep the limits of both max_active domains current
Date: Fri, 06 Nov 2026 07:42:59 -1000	[thread overview]
Message-ID: <bafc737c395f64580feac56148429264@kernel.org> (raw)
In-Reply-To: <au3smjfpG3_ic2Me@gmail.com>

Hello, Breno.

On Fri, Nov 06, 2026 at 07:10:56AM -0800, Breno Leitao wrote:
> > Maybe this means there should be further restrictions on how low max_active
> > can be pushed. For example, a workqueue created with max_active > 1
> > shouldn't be driven down to 1 in either domain, however it gets adjusted, so
> > that whether a workqueue can end up at 1 is decided by the max_active it was
> > created with. One way could be a floor of 2 in the setters and the
> > derivation for workqueues created with max_active > 1, while one created
> > with max_active 1 can still go back to 1, e.g. after being raised. That's
> > just one option though.
>
> Sure. Should the floor cover min_active as well?

Yes. For a workqueue created with max_active > 1,
workqueue_set_min_active() shouldn't take min_active below 2 either.

Thanks.

--
tejun

      reply	other threads:[~2026-11-06 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 12:33 [PATCH wq/for-7.5 v4 0/2] workqueue: Keep max_active and percpu_max_active in sync Breno Leitao
2026-10-29 12:33 ` [PATCH wq/for-7.5 v4 1/2] workqueue: Move the initial max_active setup into a helper Breno Leitao
2026-10-29 12:33 ` [PATCH wq/for-7.5 v4 2/2] workqueue: Keep the limits of both max_active domains current Breno Leitao
2026-10-29 19:07   ` Tejun Heo
2026-11-06 15:10     ` Breno Leitao
2026-11-06 17:42       ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bafc737c395f64580feac56148429264@kernel.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®