From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charles Hsu <hsu.yungteng@gmail.com>,
linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, corbet@lwn.net
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: hwmon: add STEF48H28
Date: Fri, 16 Jan 2026 10:19:31 +0100 [thread overview]
Message-ID: <bafd22ce-2916-4d22-8bba-1b7c3052f087@kernel.org> (raw)
In-Reply-To: <20260116085802.696661-1-hsu.yungteng@gmail.com>
On 16/01/2026 09:58, Charles Hsu wrote:
> +properties:
> + compatible:
> + enum:
> + - st,stef48h28
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
This must be additionalProperties instead, see speeches/presentations
material or very explicit rule in writing bindings.
OTOH, this is so trivial now, that you could just add it to
trivial-devices schema.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-01-16 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 8:58 Charles Hsu
2026-01-16 8:58 ` [PATCH v6 2/2] hwmon: pmbus: add support for STEF48H28 Charles Hsu
2026-01-16 9:19 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bafd22ce-2916-4d22-8bba-1b7c3052f087@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=hsu.yungteng@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®