From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=65.21.61.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030531; b=OiOgkGmtOSBiup16HcnazkY8bUGu9ynbAYrHGbSAvwXRUnDugirSeXMKa6eK9w42Jz2l 8UVddBPJaRzJoWZh0iTxDRhP2d80tCi3bNYWKcInS5dlAWpEK+ogv6UhTybSdWs52oSRf mLKg88OcHSiT3NvzRPg6n5A8IhqGR5L2zDb+6SQZRpxu4duycpq4ZR8KuGDefFRHUaLVW CqD92zypb89n3tqObtLVdF85e0fvWp8XpXCmx9V5hxVXxACFCkjpnCw78HEgIuHVRAWuV g65f+K/Ao9m+ulUBFmdYEQwJXCttcXUv99fr/hapum5uysVuFrUrQpVfrnvlBvxawXA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030531; h=DMARC-Filter:Message-ID:DKIM-Signature:Date:MIME-Version:User-Agent: From:Subject:To:Cc:References:Content-Language:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=mm0Tlr+mV6dnPz8Xs2eWla4wTBomddtD84Q9Vn5aR0U=; b=G/MJLJh0aWA3fJ5ZOLa4DkuVm8buhpSKUxuxjg20JbzCDp8Yv9ckdodcZuMqXkyFS/3E e1WszcuRKu55LfnrUem5spRcEE2fF2F6lsVy9pWR7OzZdSzLpKBw171EfccTa3jB79bZu Ul4GCxVY3okolEpdnnb8lL7A5Ibut34zwGKQ3RypYEQcsoYXGJVfCZfkPj2o11x3QH0Or SgJbUWenyBNgvuxCKnDPO6LzIqFmSPdH0cgWSTv++QJ59mGYnUWDt2cgMLBVaHYQ6C9tH WRKhQHldrpZX0tpEs3k1qkKRvqL87NgQHXexAeYr6X2ALw5UROyXvuTlnDkUh/8qorQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=aliel.fr; spf=pass smtp.mailfrom=aliel.fr; dkim=pass header.d=aliel.fr header.i=@aliel.fr header.a=rsa-sha256 header.s=courrier-s1 header.b=ndG0zBXt; arc=none smtp.remote-ip=65.21.61.41 Received: from courrier.aliel.fr (courrier.aliel.fr [65.21.61.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE5E606C419; Wed, 18 Nov 2026 19:35:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4DE5E606C419 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aliel.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aliel.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=aliel.fr header.i=@aliel.fr header.a=rsa-sha256 header.s=courrier-s1 header.b=ndG0zBXt Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr; s=courrier-s1; t=1795030528; bh=q1cF5XXNw8wayh7tmwKgKYk42pA4x2pEosRpTQBiONs=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=ndG0zBXtIkXmu8cIOYlH+3B1SMMIDc0k+dvgANzIY8Ozgmjct+TTGgEoa7gSphunO 0AXufkyeSVgWo3D6KVe6HRmfyLS3iX46o/Pl+5HbAgr5n5x9SLYhGz28KNTSqlOcPY MsHPzH5KILeT1ZpzQl3i4QUKSPEqHlbunwygoMmE= Date: Wed, 18 Nov 2026 20:35:26 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: linux-kernel-dev@aliel.fr Subject: Re: [PATCH 00/10] phy/drm: amlogic: Extract Meson HDMI TX PHY into a dedicated driver To: Neil Armstrong Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Vinod Koul , Manivannan Sadhasivam , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20261117-meson-drm-create-hdmitx-phy-v1-0-9e0ac931381c@aliel.fr> <51831581-525f-418c-86ea-3b5c6a80709b@linaro.org> Content-Language: en-US In-Reply-To: <51831581-525f-418c-86ea-3b5c6a80709b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/18/26 13:38, Neil Armstrong wrote: > Hi, > > On 11/17/26 20:33, Ronald Claveau via B4 Relay wrote: >> This series moves the Amlogic Meson HDMI TX PHY handling (covering GXBB, >> GXL, GXM, and G12A SoCs) out of the meson_dw_hdmi DRM driver and into a >> dedicated generic PHY driver. >> >> Until now, meson_dw_hdmi directly manipulated the HHI system controller >> registers (HHI_HDMI_PHY_CNTL0..5) to configure analog parameters, toggle >> resets, and manage power states, as well as manually ungating HDMI >> clocks and power domains already described in the DT. >> >> By extracting this logic into a standalone PHY driver under >> drivers/phy/amlogic/: >> - Hardware representation in the DT is cleaner, modeling the HDMI TX PHY >>    as a child node of the HHI syscon referenced via standard "phys" and >>    "phy-names" properties. >> - The DRM bridge driver relies on the standard generic PHY API >>    (phy_init, phy_configure, phy_power_on/off, phy_exit) rather than >>    touching syscon registers directly. >> - Legacy DTs lacking the "phys" property remain supported via a >>    temporary fallback helper (meson_hdmi_phy_create_legacy) to preserve >>    backward compatibility to be removed on next phase of component >>    removal. >> >> Overview of the series: >> - Patches 1-3: Fix compatible matching in meson-gx-hhi-sysctrl bindings, >>    add the new amlogic,meson-hdmi-tx-phy DT schema, and allow the >>    "hdmi-phy" child node under the HHI syscon. >> - Patch 4: Add the new Meson HDMI TX PHY driver implementing the HDMI >>    PHY configuration ops, along with the temporary legacy creation >>    helper. >> - Patch 5: Document the optional "phys" and "phy-names" properties in >>    the amlogic,meson-dw-hdmi binding. >> - Patches 6-7: Clean up manual HHI clock/power-domain writes in >>    meson_dw_hdmi (relying on runtime PM instead) and convert the driver >>    to use the generic PHY framework. >> - Patches 8-10: Add the "hdmi-phy" child node and wire up the "phys" >>    phandle for G12, GXBB, and GXL Device Trees. >> >> Tested on: >> - Khadas VIM1 (GXL) >> - dtbs_check and dt_binding_check run cleanly with no new warnings. >> >> Signed-off-by: Ronald Claveau >> --- >> Ronald Claveau (10): >>        dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Fix compatible >> matching in conditionals >>        dt-bindings: phy: amlogic: Add Meson HDMI TX PHY binding >>        dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy >> child node >>        phy: amlogic: Add Meson HDMI TX PHY driver >>        dt-bindings: display: amlogic,meson-dw-hdmi: Add phys and phy- >> names >>        drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup >>        drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI >> TX PHY >>        arm64: dts: amlogic: Add HDMI TX PHY node for G12 >>        arm64: dts: amlogic: Add HDMI TX PHY node for GXBB >>        arm64: dts: amlogic: Add HDMI TX PHY node for GXL >> >>   .../bindings/display/amlogic,meson-dw-hdmi.yaml    |   8 + >>   .../bindings/phy/amlogic,meson-hdmi-tx-phy.yaml    |  33 +++ >>   .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml  |  43 ++- >>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi  |   7 + >>   arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi        |   7 + >>   arch/arm64/boot/dts/amlogic/meson-gxl.dtsi         |   7 + >>   drivers/gpu/drm/meson/Kconfig                      |   1 + >>   drivers/gpu/drm/meson/meson_dw_hdmi.c              | 203 ++++++-------- >>   drivers/phy/amlogic/Kconfig                        |  11 + >>   drivers/phy/amlogic/Makefile                       |   1 + >>   drivers/phy/amlogic/phy-meson-hdmi-tx.c            | 309 +++++++++++ >> ++++++++++ >>   include/linux/phy/phy-meson-hdmi-tx.h              |  19 ++ >>   12 files changed, 513 insertions(+), 136 deletions(-) >> --- >> base-commit: 6d582d78fad9d828e575ca0cdcff8ea47a77220b >> change-id: 20261115-meson-drm-create-hdmitx-phy-4ac40a654d09 >> >> Best regards, >> -- >> Ronald Claveau > > Overall it's very good, but I would've prefered a more sequencial move > to the PHY driver, with an exact copy of the code and simplification > towards the current PHY code. > > Anyway, the sashiko review comments are good, especially the one on > patch 6 to keep the driver working on old DTs, sorry my bad... > > Neil Thanks for your feedback, I am analyzing/testing sashiko feedback. About the suspend/resume unbind/bind, I do not have any issue on my side, but I can change the orders. About patch 6 and the old DTs, I will reintroduce them with the legacy check. Do you know what would be a good timeline to add a require on those elements and drop the fallback code ? -- Best regards, Ronald