From: Philipp Zabel <p.zabel@pengutronix.de>
To: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Todd Kjos <tkjos@google.com>, Alistair Delva <adelva@google.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate
Date: Tue, 07 Jan 2020 09:32:56 +0100 [thread overview]
Message-ID: <bb0651eb7b1c81755ec43fe9d85f27a5fd83af88.camel@pengutronix.de> (raw)
In-Reply-To: <20200107010350.58657-1-john.stultz@linaro.org>
On Tue, 2020-01-07 at 01:03 +0000, John Stultz wrote:
> Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> to allow for the driver to be loaded from a modules.
>
> Cc: Todd Kjos <tkjos@google.com>
> Cc: Alistair Delva <adelva@google.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 3ad7817ce1f0..45e70524af36 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> This enables the reset driver for ImgTec Pistachio SoCs.
>
> config RESET_QCOM_AOSS
> - bool "Qcom AOSS Reset Driver"
> + tristate "Qcom AOSS Reset Driver"
This doesn't seem right on its own, the driver still uses
builtin_platform_driver().
regards
Philipp
next prev parent reply other threads:[~2020-01-07 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 1:03 John Stultz
2020-01-07 1:38 ` Bjorn Andersson
2020-01-07 8:32 ` Philipp Zabel [this message]
2020-01-07 17:23 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb0651eb7b1c81755ec43fe9d85f27a5fd83af88.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=adelva@google.com \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®