mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kiseok Jo <kiseok.jo@irondevice.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ASoC: codec: sma1307: replace spelling mistake with new error message
Date: Fri, 8 Aug 2025 12:35:40 +0100	[thread overview]
Message-ID: <bb06d3bf-684b-4479-8b86-72aed622e453@gmail.com> (raw)
In-Reply-To: <f646f36e-7835-415d-8da7-fc632c57e4e2@sirena.org.uk>


[-- Attachment #1.1.1: Type: text/plain, Size: 868 bytes --]

On 08/08/2025 12:30, Mark Brown wrote:
> On Fri, Aug 08, 2025 at 11:53:24AM +0100, Colin Ian King wrote:
> 
>> There is a spelling mistake in a failure message, replace the
>> message with something a little more meaningful.
> 
>>   	if ((sma1307->set.checksum >> 8) != SMA1307_SETTING_CHECKSUM) {
>> -		dev_err(sma1307->dev, "%s: failed by dismatch \"%s\"\n",
>> +		dev_err(sma1307->dev, "%s: checksum failed \"%s\"\n",
> 
> It's definitely an unusual term and the reword makes sense but that does
> make sense to me as a word, I don't think it's a spelling error as such.

"Dismatch" is not a standard English word. It's likely a misspelling of 
"mismatch" or a neologism formed by adding the prefix "dis-" to "match". 
I understand it a niche term, I just think it is preferable not to use 
it for folk who's first language isn't English.

Colin

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2025-08-08 11:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 10:53 Colin Ian King
2025-08-08 11:30 ` Mark Brown
2025-08-08 11:35   ` Colin King (gmail) [this message]
2025-08-08 12:10     ` Mark Brown
2025-08-12 11:05 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb06d3bf-684b-4479-8b86-72aed622e453@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kiseok.jo@irondevice.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®