From: Lars Persson <lars.persson@axis.com>
To: Michal Marek <mmarek@suse.com>, Lars Persson <larper@axis.com>
Cc: <linux-kernel@vger.kernel.org>, <arnd@arndb.de>
Subject: Re: [PATCH] kbuild: do not add srctree to sysroot relative includes
Date: Tue, 16 Aug 2016 14:22:35 +0200 [thread overview]
Message-ID: <bb0a668c-ed4c-143f-4796-72d3caa05996@axis.com> (raw)
In-Reply-To: <90494889-24e4-64be-422e-d7cc344f03da@suse.com>
On 08/16/2016 01:59 PM, Michal Marek wrote:
> On 2016-08-16 13:40, Lars Persson wrote:
>> We need to filter out also -I=/path to allow sysroot relative
>> include paths in the makefiles of external modules.
>>
>> Signed-off-by: Lars Persson <larper@axis.com>
>> ---
>> scripts/Kbuild.include | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
>> index 1792198..ffe5c6c 100644
>> --- a/scripts/Kbuild.include
>> +++ b/scripts/Kbuild.include
>> @@ -206,7 +206,7 @@ hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>> # Prefix -I with $(srctree) if it is not an absolute path.
>> # skip if -I has no parameter
>> addtree = $(if $(patsubst -I%,%,$(1)), \
>> -$(if $(filter-out -I/% -I./% -I../%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1)))
>> +$(if $(filter-out -I/% -I./% -I../% -I=%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1)))
>
> Hi Lars,
>
> Two questions: 1) Where is the -I=/... syntax documented? I could not
> find it gcc docs.
You should find this in your gcc manual:
If dir begins with "=", then the "=" will be replaced by the sysroot
prefix; see --sysroot and -isysroot.
2) Why do these Makefiles use --sysroot at all? The
> kernel does not use any system libraries and the host programs are
> compiled for the host architecture.
One use-case is with the yocto build system. Suppose we have two kernel
modules A and B. A installs header files into the sysroot that B will
include.
- Lars
prev parent reply other threads:[~2016-08-16 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 11:40 Lars Persson
2016-08-16 11:59 ` Michal Marek
2016-08-16 12:22 ` Lars Persson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb0a668c-ed4c-143f-4796-72d3caa05996@axis.com \
--to=lars.persson@axis.com \
--cc=arnd@arndb.de \
--cc=larper@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®