From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863C28BEA for ; Mon, 23 Dec 2024 15:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734966134; cv=none; b=hNf4HAStdXot9xTFHvHgLRo6ZiYHe34DKEixBJZ3M6KTCbmRYb9UQI83FAdQeBDq7JVjkCIhZDAWPfWZ3fSdlpZFCBzSwuM3BFG3AAos5rW7v9DGxkQF4MEQZk8AlX02aGinJ7W2yPJayz/zh2R8KItFSFE1R+fjuFL5MpCdwvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734966134; c=relaxed/simple; bh=dKdkPWcMSXLtrM9Npj7ucy3xgkvL5YhguGEGgNelouo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZIa427AIrBAX3JI44cK7kKwypQNbdfkc6HHR/hi1JL1kkW1wOODciJMrvcc4fWCWVATKFSYmAsiQ8yRDmu0Fv2GpEuCJCAPaZWCUAsfmJFt01ZvyDSZTh4aXnbmNi+JIz03iDXr6gNqk3jJ2Op5MDimErU/GP50hc1MJYdgMP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eBrYV+1Z; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eBrYV+1Z" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5d0bf4ec53fso701023a12.0 for ; Mon, 23 Dec 2024 07:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734966131; x=1735570931; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uwnSFgDadgTc3T1TLFoBCCrNqUGPpUfqlwWEQstuxE0=; b=eBrYV+1ZOG1VLmoGyIaWIrEIMlF7ofyTqcO5h8GUQkHW267+cINpdUzXYdngoelBd2 /zoeIttNIfI4RwdqXfVdFEMnf7DkMMfHhMpJzOf3Yr+S+CcUp2aQgw9HZZpMh53Et6+G BtU1vk5H/VHOcSz8iWBBn0YNOk14/ISYuBb/9AnUIHNNaYO3o0w+pUumzDvdccWAUr7c n01XRG2WVmQlHEI055Bx7FY9yuCP3kK4kqfDGUNck23zvf/cdZGPU62uNJlooFmliZYh UMjgQSDRfpHx0UTklRtNq8fCLjhdIwsGfzzt8cEdd3+8eGEF7+8SLXNMQUYBuuSnBbOp IPzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734966131; x=1735570931; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uwnSFgDadgTc3T1TLFoBCCrNqUGPpUfqlwWEQstuxE0=; b=d3UQtRWc9cF2IOxaxfKDFt2CGMyPohgQsUYlP8+PW7zPEV8wVLSLBwb4AsvaDSWfac +0/B7/GhlSUt+o0KzBy4z9aj3rKVuiErfYEuC5UhLGYamxGgQ+r4sh2aLmQCy6Z3txCv fsIjHZ4Z5VrbOLO966325+WvMcr6riIs/+QVUlX1ElQjnma8ae+nTTtfpX/R/NK0/wWv C5g+dY9WBlG+u/sn7Yi0RfSvxR0qLBZkKZ9PupvrJT3fG68ykvAoJzDtDJmnm9U6Kfl9 5kE1XCmJ8UCF3cleL7+dOP4zgUIc8x1Wy4PHb8S3Hvj7BWsLKE7bYSzPWrxV00WC3IGU 7pow== X-Forwarded-Encrypted: i=1; AJvYcCV+ePEBdW6YPjZiLkSL/QWSkGIGXMjMr5nWcRp8d6UroVojmjySu1GBxeCehn+WQHQ3VgikLz7ooZBOlxc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9xFmx5P9fYC2dAgRBLPtYZkZyabK/D4m2xzXZRMQKNKZhSD66 iGuM6fwT644h3z3Xwd5oMgb9evEXtiMPPfcwkWY1AM2m3D2sxnQAiqfNz5ZMXxY= X-Gm-Gg: ASbGncuRE4Qq6hZhsBb1drGuXLH2Z88eNxE8Ck3B+fyyjplSLpbhU+iPmtqsik1Vs0Z FyUFW1DvDSS55RZuSH8u/5OxTWaV04JCGBfbZPK4IqviygosQF23tFwuRBF5DKe4edfAzWtUYXs S3vUxdS9l1ISwoiMh3ok7t0DCJTOxTYRwsP/Y2yZPRZmbZYyNaoO9ebi25XkghlvOlwVqFy8kAw U4IGB9J0Z9vt0hnQvrFJEu3PvHGRgppT7mRw3/vO1o/+BZLVmotYgV55y/9akWfalks0vfCpr9I h7KuTd+EVIpd5F1nw6bULzoJt2Y9qmgRnKU= X-Google-Smtp-Source: AGHT+IFI1AwhHGpeMdbhrWdDQ8Jqv51uktzLfhqIF7Cfg7yHWuYfd7IvvrsZFd9atccoGpd7CvrwRQ== X-Received: by 2002:a05:6402:51cc:b0:5cf:cc32:82f2 with SMTP id 4fb4d7f45d1cf-5d81ddaf985mr3671235a12.5.1734966129863; Mon, 23 Dec 2024 07:02:09 -0800 (PST) Received: from [192.168.0.18] (78-11-220-99.static.ip.netia.com.pl. [78.11.220.99]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80676f3f9sm5002281a12.23.2024.12.23.07.02.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2024 07:02:08 -0800 (PST) Message-ID: Date: Mon, 23 Dec 2024 16:02:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mfd: syscon: Allow syscon nodes without a "syscon" compatible To: "Rob Herring (Arm)" , Lee Jones , Arnd Bergmann , Pankaj Dubey , Heiko Stuebner , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Cc: Peter Griffin , Will McVicker , John Madieu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> <20241217-syscon-fixes-v2-3-4f56d750541d@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20241217-syscon-fixes-v2-3-4f56d750541d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/12/2024 19:11, Rob Herring (Arm) wrote: > of_syscon_register_regmap() was added for nodes which need a custom > regmap setup. It's not really correct for those nodes to claim they are > compatible with "syscon" as the default handling likely doesn't work in > those cases. If device_node_get_regmap() happens to be called first, > then of_syscon_register() will be called and an incorrect regmap will be > created (barring some other error). That may lead to unknown results in > the worst case. In the best case, of_syscon_register_regmap() will fail > with -EEXIST. This problem remains unless these cases drop "syscon" (an > ABI issue) or we exclude them using their specific compatible. ATM, > there is only one user: "google,gs101-pmu" > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof