From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbdDZQxM (ORCPT ); Wed, 26 Apr 2017 12:53:12 -0400 Received: from mout.web.de ([212.227.17.12]:55147 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbdDZQxE (ORCPT ); Wed, 26 Apr 2017 12:53:04 -0400 To: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, James Liao , Kevin Hilman , Matthias Brugger , Sascha Hauer , Shunli Wang From: SF Markus Elfring Subject: [PATCH] soc: mediatek: Use devm_kcalloc() in init_scp() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: Date: Wed, 26 Apr 2017 18:52:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:AEUlDX+8pS/5IijfbpstVISpZ6/dVHggtT/YOOv0jyfFdyFN+fm wPoO6huqbwMn/XzH2OIRgnYm5tFQjJ0gyIHpn0PokEIuhEgbsDI8ifDSi9nRaFoIT1r/Z/i D6GLyWahvXfA5fmoHYVX0w7elMq9Ge7+7vdOajsSjLFkUIgKIuywLEJEx5Q93+02u60RJsI vj/ptFTtNFVI99omK/+hg== X-UI-Out-Filterresults: notjunk:1;V01:K0:gK/+PvWenxA=:rDqKJODanCxYWBF4Y7B5GN J+ZUEm3Ye7L4PfvWfdh8aWmack+Zdp+htNGOULcbzjf1euwy0oltJeeFyBbnQhYlo10GWgw/h xzNmrojw8ZNRGf/YBYmaJqtBhBp89qSOP197O9wCGybA0k4QMAQutHdTgD8L5i4m7/dUlHxs2 TleE5EDGwlqnY64dEkmPtM7W6tghOabAlx34W/64zaWHbu12rOd2aqPsn0+ytp0EcSLvi/XAq LFnbgKXCnHxQuV3rHX+Eo2EhWt/BRtGobhx4r23GznXu9cTxQO/DP6OanIYqjlagG6k7wBq1i TLMsQnbAykeSZIVfWseYPIiwq5eSWE4yag8M5kssXJ/P5+WoQZRqHrW6eBnawoHqF58Bgeew2 PKoFR4P36nt7CCulLhZtJPHs80ZbLuFfvX58TkLdsL+xMJX98pLm5fntPjgz8osoMQVU5hXt9 pLeP2YSbFJQuiW3dHl/gA6rF1Dbxux1Ilotz49eX60WrQv+GMsgbbabYPU/f45kkXGr3CCy9R I/0Lk4UOfnV01L76DK8Mbe01Vs8AhKMMeIXRh7M3RFrlpZwMlN6YssdCjNBSr3Vudoz77Dx99 Nt82cFZmn+A7p/sVXUoet+sSTBzFdBK6CQR1Wp6DbWv2Q83fVhBakUOt1rwPyZu05kY4IXfDb 9gqW7B/3ZiJfogyJiE+PpVxOfnjiinAtj05VimZeunlttGOtOivoUbLrRqa/RXDIFLz87MYK/ 6m/V77NQmqmy1K8/K1DkzKmEB5cJdZaXtNv2Vx0fJSbhwIpRPDBakNjjz+Yov0h2ZH+Esz5OD E47/pxs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 26 Apr 2017 18:33:15 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "devm_kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/soc/mediatek/mtk-scpsys.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index beb79162369a..9abf2b067ec6 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -365,15 +365,14 @@ static struct scp *init_scp(struct platform_device *pdev, if (IS_ERR(scp->base)) return ERR_CAST(scp->base); - scp->domains = devm_kzalloc(&pdev->dev, - sizeof(*scp->domains) * num, GFP_KERNEL); + scp->domains = devm_kcalloc(&pdev->dev, num, sizeof(*scp->domains), + GFP_KERNEL); if (!scp->domains) return ERR_PTR(-ENOMEM); pd_data = &scp->pd_data; - - pd_data->domains = devm_kzalloc(&pdev->dev, - sizeof(*pd_data->domains) * num, GFP_KERNEL); + pd_data->domains = devm_kcalloc(&pdev->dev, num, + sizeof(*pd_data->domains), GFP_KERNEL); if (!pd_data->domains) return ERR_PTR(-ENOMEM); -- 2.12.2