From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F89CC4332F for ; Tue, 31 Oct 2023 17:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345827AbjJaRiD convert rfc822-to-8bit (ORCPT ); Tue, 31 Oct 2023 13:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbjJaRiC (ORCPT ); Tue, 31 Oct 2023 13:38:02 -0400 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50A9E8F for ; Tue, 31 Oct 2023 10:38:00 -0700 (PDT) Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C3EC614054F; Tue, 31 Oct 2023 17:37:58 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA id 769DD2E; Tue, 31 Oct 2023 17:37:56 +0000 (UTC) Message-ID: Subject: Re: [PATCH] staging: vme_user: Added blank line after declarations From: Joe Perches To: Dan Carpenter , Rohit Chavan Cc: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Date: Tue, 31 Oct 2023 10:37:55 -0700 In-Reply-To: References: <20231031100610.5394-1-roheetchavan@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Stat-Signature: s8hwmqg7or3yfsm3hceq5mpkyw5b89g8 X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: 769DD2E X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+Y4Lk5Ohe0duQ7Weqxvd7e66sww4hsK+w= X-HE-Tag: 1698773876-869344 X-HE-Meta: U2FsdGVkX1/+yg2e3ycIbFUpTqfxJW+WHsv8ya/jnYXVh4yCEPg0y+kcguw6Jg+rPpeQixm7CyarqEHh643ZGgo7S9UTy6j55/ajH0Gi4ndmPsDJpPHhA4PpHsoRKzqPYcs1YUtGa8x9Wc2lpYh212UfcxE3OyGjo7oL9oVoSCPSsI2zBOL2i76j46LMRBtRY4MelopTT9Y6J3kxpeqkvqgUQ7Jn/BfFo7Lv9c06nwFs2wmT3ulrAMskVedBeXDo1plGg60xGeJyDFgLdpxS0mi8s7llSlP5OvkNnvuBAsMkjBZ590hj1+tQdi3r9z6LhLrrm1UcJ9b5CFeWMVojxovus+Fgucwo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-10-31 at 13:27 +0300, Dan Carpenter wrote: > On Tue, Oct 31, 2023 at 10:06:10AM +0000, Rohit Chavan wrote: > > Fixes below warning reported by checkpatch. > > WARNING: Missing a blank line after declarations > > > > Signed-off-by: Rohit Chavan > > This is a checkpatch false positive. (It's not "after declarations"). > Just ignore it. > checkpatch could accept function pointer and function pointer arrays --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 25fdb7fda1128..de1f4962f55d6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1073,6 +1073,7 @@ our $Typecast = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*}; # Any use must be runtime checked with $^V our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/; +our $balanced_brackets = qr/(\[(?:[^\[\]]++|(?-1))*\])/; our $LvalOrFunc = qr{((?:[\&\*]\s*)?$Lval)\s*($balanced_parens{0,1})\s*}; our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)}; @@ -4107,7 +4108,7 @@ sub process { # looks like a declaration !($sl =~ /^\+\s+$Declare\s*$Ident\s*[=,;:\[]/ || # function pointer declarations - $sl =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident\s*\)\s*[=,;:\[\(]/ || + $sl =~ /^\+\s+$Declare\s*\(\s*\*\s*$Ident(?:\s*$balanced_brackets)*\s*\)\s*[=,;:\[\(]/ || # foo bar; where foo is some local typedef or #define $sl =~ /^\+\s+$Ident(?:\s+|\s*\*\s*)$Ident\s*[=,;\[]/ || # known declaration macros