From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932594AbcGDItH (ORCPT ); Mon, 4 Jul 2016 04:49:07 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35792 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932189AbcGDItD (ORCPT ); Mon, 4 Jul 2016 04:49:03 -0400 Subject: Re: [PATCH 0/2] KVM: MMU: support VMAs that got remap_pfn_range-ed To: Xiao Guangrong , Neo Jia References: <1467291711-3230-1-git-send-email-pbonzini@redhat.com> <577A049A.4000402@linux.intel.com> <20160704070314.GA13291@nvidia.com> <577A123F.1060909@linux.intel.com> <8ff54c7b-2e64-4503-03f6-1a858d9d5746@redhat.com> <577A1765.6080606@linux.intel.com> <577A1C93.3010204@linux.intel.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Kirti Wankhede , Andrea Arcangeli , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= From: Paolo Bonzini Message-ID: Date: Mon, 4 Jul 2016 10:48:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <577A1C93.3010204@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2016 10:21, Xiao Guangrong wrote: >> >> /* >> * In case the VMA has VM_MIXEDMAP set, whoever called >> remap_pfn_range >> * is also going to call e.g. unmap_mapping_range before the >> underlying >> * non-reserved pages are freed, which will then call our MMU >> notifier. >> * We still have to get a reference here to the page, because the >> callers >> * of *hva_to_pfn* and *gfn_to_pfn* ultimately end up doing a >> * kvm_release_pfn_clean on the returned pfn. If the pfn is >> * reserved, the kvm_get_pfn/kvm_release_pfn_clean pair will simply >> * do nothing. >> */ >> > > Excellent. I like it. :) So is it Reviewed-by Guangrong? :) Paolo