Re: [PATCH 4.19 000/132] 4.19.284-rc1 review

[Guenter Roeck <linux@roeck-us.net>]

On 5/29/23 07:28, Naresh Kamboju wrote:
> On Mon, 29 May 2023 at 19:19, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On Mon, May 29, 2023 at 06:48:10AM -0700, Guenter Roeck wrote:
>>> On Sun, May 28, 2023 at 08:08:59PM +0100, Greg Kroah-Hartman wrote:
>>>> This is the start of the stable review cycle for the 4.19.284 release.
>>>> There are 132 patches in this series, all will be posted as a response
>>>> to this one.  If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Tue, 30 May 2023 19:08:13 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>
>>> Building s390:defconfig ... failed
>>> Building s390:allnoconfig ... failed
>>> Building s390:tinyconfig ... failed
> 
> We do noticed these set of build failures,
> 
> Seems like the following commit might have caused this
> build break
> 
>   drivers: provide devm_platform_ioremap_resource()
>    [ Upstream commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ]
> 
> 

Yes. devm_ioremap_resource() is only defined with CONFIG_HAS_IOMEM,
That dependency was added to platform.c with commit 837ccda3480d
("drivers: depend on HAS_IOMEM for devm_platform_ioremap_resource()")
which wasn't backported.

Guenter

>>>
>>> --------------
>>> Error log:
>>> s390-linux-ld: drivers/base/platform.o: in function `devm_platform_ioremap_resource':
>>> drivers/base/platform.c:97: undefined reference to `devm_ioremap_resource'
>>> madrivers/base/platform.cke[1]: *** [Makefile:1061: vmlinux] Error 1
>>> make: *** [Makefile:153: sub-make] Error 2
>>
>> This also affects um:defconfig.
>>
>> Guenter
> 
> - Naresh