mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Gold Side <goldside000@outlook.com>,
	"perex@perex.cz" <perex@perex.cz>,
	"krzk@kernel.org" <krzk@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>
Subject: Re: [PATCH 2/3] Removed extra asterisks from comment beginnings, and removed unnecessary comment end
Date: Sat, 6 Jul 2024 21:47:09 -0700	[thread overview]
Message-ID: <bb18f151-2c38-4dfa-95a9-cb674d169343@infradead.org> (raw)
In-Reply-To: <DM4P223MB054139F737887D40A2CA396FF7D92@DM4P223MB0541.NAMP223.PROD.OUTLOOK.COM>

Hi--

On 7/6/24 9:14 PM, Gold Side wrote:
> From 33dc0aa3973913f310840cc8f7d5d599d573c297 Mon Sep 17 00:00:00 2001
> From: Steven Davis <goldside000@outlook.com>
> Date: Tue, 2 Jul 2024 23:43:15 -0400
> Subject: [PATCH 2/3] Removed unnecessary comment end
> 
> It still works the same without that comment end, so why is it in there?

Building with clang should report a warning similar to this:

error: '/*' within block comment [-Werror,-Wcomment]

which is not acceptable.

> Signed-off-by: Steven Davis <goldside000@outlook.com>
> ---
>  include/memory/renesas-rpc-if.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h
> index b8fa30fd6b500c..591dd86f55f879 100644
> --- a/include/memory/renesas-rpc-if.h
> +++ b/include/memory/renesas-rpc-if.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> +/* SPDX-License-Identifier: GPL-2.0
>  /*
>   * Renesas RPC-IF core driver
>   *
> 

-- 
~Randy

  reply	other threads:[~2024-07-07  4:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-07  4:14 Gold Side
2024-07-07  4:47 ` Randy Dunlap [this message]
2024-07-07 11:21 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb18f151-2c38-4dfa-95a9-cb674d169343@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=goldside000@outlook.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®