From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C1D223958D for ; Sun, 29 Mar 2026 05:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774760758; cv=none; b=s/yn4aHAJBbSkpbgIxk2XXwc6ctZ8lf1Dk/8SRDpcLUZFdysz0n43PHmRxaGl20AsQON4DJrLnBamdfqp9dFa12NIaFpfCKmxomUrWY6/OLozeDIyvMbUgOki2lNWq6Ldtc45CUn10F5HSAZGazAeMgA4FP/SSLFDmpj0hSnZ0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774760758; c=relaxed/simple; bh=Kk3dWar8Quu1OSZMiLbSq19BiVddLPomPfiOafDZE7A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m4ZxtVCfzapdBXdGPHOH6VxCBXW5b73llqVbgjBeU17BiHtoJ8P1efnXGMll5hgEI6vP/ABQk43AtfEWVx5hWgGVB/6bDtna4Taa05IM8FeD3BoLyuXMKxWm9RwoHM2E+AJ62zIfFB21hs7Q9PPUcyUUpfNcsQuFucE7KncgE6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WwMiyP25; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WwMiyP25" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b042533de1so19048975ad.0 for ; Sat, 28 Mar 2026 22:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774760757; x=1775365557; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zntGvzqjvnyYriEFd2VuM836jbP6Fi+HoD3l/aq/GrI=; b=WwMiyP25qHhMPuXRl4nm5TXJ23n/5TW97V40Om4aD8/I7k96NViD2mX4lNxRsGCGA2 GLxNWHJ8ZY0PD0kOWRO0iz8icxePAXx628iV7tChAyAUG+fc8Z6yeAu8GVTO/v8qRX8Y 7RCB0+Eva5EIn/lQ0vMzmIkvZB64jNrfm69MA62Hm/Fzv1IaC4/TlH8M9u3to5aIfTfQ Ch2aGG1IXKGWYiT8CpZD+pdVk3hrTMLtL7u0aZaMQmW18tnUjy38szDVqlrDApZYqACu Keub0jzx/oRsTDrCEswvVy+ebp8/b6eb6VCYsMwtbrwkraBooyWL9Iu3vmOoXOKJPVbj tbiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774760757; x=1775365557; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zntGvzqjvnyYriEFd2VuM836jbP6Fi+HoD3l/aq/GrI=; b=JFYivIiWj0GJY49/PosOzyoAqlz/erQQ2/PIx14p2HKIGZ90Y3fwfSeJdNHc4CX3dd sDij3iz4u36lwOSqkcUlqNlkb3H75mNY2TOyo3HCKXQGFdkwiF9jUSb+tTlRu/pZwjNi Uxat4tiAqYEH3NjBffWE0Um3BQfX3Buny8PYWwA++H/9q04elXL3VJEI7dxz/+4jEema QoR28GyRJipIr8u1m03qK2Xx3IMBH8HErlp4o35ffEJ1tThGKQWGvEy11f12lsguFLuw i2Tdf8wvUJUlXLCTvA5zvCgJ6achNj40tNsaj87KXFgE4lats+zGM8OfVYY9a19NrAsI EY6A== X-Forwarded-Encrypted: i=1; AJvYcCUWNSGhy6jbcmQuifIaXn8C4AA+L9dfzwtxbcVNymrDQu6sVWAbxy4PjA4EHY7odaSscfnT6oQIOJUX/MU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3aKkZt+aTwy0OeMl5s7yRRC8OEtbqHxqqXOhtmNHlAC+is++S 9ZlhzDq/8/qLw37vKI6eb8pD4vmRLv9yTJr+Zgf4aniQtPLPANxjaSAh X-Gm-Gg: ATEYQzx44/gh7t25VIzGE5HAtC5quirqcL0zKdQ3wY0OkxR69Y7AoPaKaJcgHwa85lp t7t24SBpCV7RyCLNY+u9jO2oeNdcrLvOsxxooLImNnlLJ7FKRc/dEtNdQq1ZIkBQNd2yJr98mhC xW8brG+7KDb0PWN5fcftAYFICAgogjygx3fa+pBk2Ufy4CbUEIHU5OXtx3kEvZlxBbBXUANGJj+ nkLqkiAmnEaCCKae7uBVzDsNtu5SDdCMeU83AjKLjmA3gIkym0Kf6dEQJCsq6mTZsA4kdg3LJUM CC4I90NlMB1KmuPDYBIZYFOXdSR2oiUB4icbSGSeJ8fAucoHGesXMpqOVHCwW9k4G35tRvGKPE5 aDRpieHalniaLB7SkutvvXMZP7+rBD1LLkcX6BVeNJgS9MdV8on2LDKGciSWzrIrD2o16pbuvHa qBjyLPoeavumCYUHoWK7/5/YCpI82c8jQHn07aVomrbTZPlkYqq+IlyTQaXFAth2MT2bwvkVmBX plFn7yr8bl9/cwefuR4JQ== X-Received: by 2002:a17:902:fc4b:b0:2b0:af2f:b26e with SMTP id d9443c01a7336-2b0cdcc87c7mr81635595ad.28.1774760756699; Sat, 28 Mar 2026 22:05:56 -0700 (PDT) Received: from [192.168.0.5] (124-218-201-66.cm.dynamic.apol.com.tw. [124.218.201.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242642864sm44640015ad.12.2026.03.28.22.05.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2026 22:05:56 -0700 (PDT) Message-ID: Date: Sun, 29 Mar 2026 13:05:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support To: Eric Woudstra , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@mork.no Cc: frank-w@public-files.de, daniel@makrotopia.org, lucien.jheng@airoha.com References: <20260326153518.8387-1-lucienzx159@gmail.com> <6f42d92b-a26d-49a4-bef7-2227c252eea7@gmail.com> Content-Language: en-US From: "Lucien.Jheng" In-Reply-To: <6f42d92b-a26d-49a4-bef7-2227c252eea7@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eric Woudstra 於 2026/3/28 下午 06:21 寫道: > > On 3/27/26 5:41 AM, Eric Woudstra wrote: >> static int __air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, >> u32 pbus_data) >> { >> int ret; >> >> ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_EXT_PAGE_ACCESS, >> (u16)(pbus_address >> 6)); >> if (ret < 0) >> return ret; >> >> ret = __mdiobus_write(mdio->bus, mdio->addr, (pbus_address >> 2) & 0xf, >> (u16)pbus_data); >> if (ret < 0) >> return ret; >> >> ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_PBUS_DATA_HIGH, >> (u16)(pbus_data >> 16)); >> if (ret < 0) >> return ret; >> >> return 0; >> } >> >> static int air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, >> u32 pbus_data) >> { >> int ret; >> >> mutex_lock(&mdio->bus->mdio_lock); >> >> ret = __air_pbus_reg_write(mdio, pbus_address, pbus_data); >> if (ret < 0) >> dev_err(&mdio->dev, "%s 0x%08x failed: %d\n", __func__, >> pbus_address, ret); >> >> mutex_unlock(&mdio->bus->mdio_lock); >> >> return ret; >> } >> >> static int __air_pbus_reg_read(struct mdio_device *mdio, u32 pbus_address, >> u32 *pbus_data) >> { >> int ret, pbus_data_low; >> >> ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_EXT_PAGE_ACCESS, >> (u16)(pbus_address >> 6)); >> if (ret < 0) >> return ret; >> >> ret = __mdiobus_read(mdio->bus, mdio->addr, (pbus_address >> 2) & 0xf); >> if (ret < 0) >> return ret; >> pbus_data_low = ret; >> >> ret = __mdiobus_read(mdio->bus, mdio->addr, AIR_PBUS_DATA_HIGH); >> if (ret < 0) >> return ret; >> >> *pbus_data = (ret << 16) + pbus_data_low; >> >> return 0; >> } >> >> static int air_pbus_reg_read(struct mdio_device *mdio, u32 pbus_address, >> u32 *pbus_data) >> { >> int ret; >> >> mutex_lock(&mdio->bus->mdio_lock); >> >> ret = __air_pbus_reg_read(mdio, pbus_address, pbus_data); >> if (ret < 0) >> dev_err(&mdio->dev, "%s 0x%08x failed: %d\n", __func__, >> pbus_address, ret); >> >> mutex_unlock(&mdio->bus->mdio_lock); >> >> return ret; >> } >> >> With: >> >> #define AIR_PBUS_DATA_HIGH 0x10 > Small correction using upper_16_bits() and lower_16_bits(): > > static int __air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, > u32 pbus_data) > { > int ret; > > ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_EXT_PAGE_ACCESS, > (u16)(pbus_address >> 6)); > if (ret < 0) > return ret; > > ret = __mdiobus_write(mdio->bus, mdio->addr, (pbus_address >> 2) & 0xf, > lower_16_bits(pbus_data)); > if (ret < 0) > return ret; > > ret = __mdiobus_write(mdio->bus, mdio->addr, AIR_PBUS_DATA_HIGH, > upper_16_bits(pbus_data)); > if (ret < 0) > return ret; > > return 0; > } > > static int air_pbus_reg_write(struct mdio_device *mdio, u32 pbus_address, > u32 pbus_data) > { > int ret; > > mutex_lock(&mdio->bus->mdio_lock); > > ret = __air_pbus_reg_write(mdio, pbus_address, pbus_data); > if (ret < 0) > dev_err(&mdio->dev, "%s 0x%08x failed: %d\n", __func__, > pbus_address, ret); > > mutex_unlock(&mdio->bus->mdio_lock); > > return ret; > } Thank you for your feedback. I will include this in the next version.