From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFA9C49EA4 for ; Tue, 22 Jun 2021 21:38:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBB8661042 for ; Tue, 22 Jun 2021 21:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbhFVVlE (ORCPT ); Tue, 22 Jun 2021 17:41:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:37368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbhFVVlD (ORCPT ); Tue, 22 Jun 2021 17:41:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F2756128E; Tue, 22 Jun 2021 21:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624397927; bh=z1g0VAGANwPeUAqNQcogHM1/8gPB2g8iknW3WucZ0IQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=WpGDn4sVC+SMSNx8DS0zGW4S26xRXDzLNzRb6P2Y7m+Ln9T7xdiQ4fdJvGI5587HP GT4+OKbM9uDChV9HZL2478KdI8ZCmwrDNaEELfToie9F1EjCnx1bY6ncrJ33wgXZMZ eCEK2WZs1Kr0YMXfK0N08IBPgclmqx4TtF9gCSbm9FA5Ol0iHdLHe6JzFpdWiBjind WFWoyj9o9pyT1Oxm0wRv+DxPXBj6dkF/9elLnqTnEGAKsnnFuqaauwA2kG+N7o4Udu O84/HmY/mjEaeRaaKi7X+AVQVjWVN+8PSWZXQEl5jr6UWCVR+SXxEbQY5KlD+1w1wP ieXj66aSOtVaQ== Message-ID: Subject: Re: [PATCH v2] net/mlx5: Fix missing error code in mlx5_init_fs() From: Saeed Mahameed To: Jiapeng Chong Cc: leon@kernel.org, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 22 Jun 2021 14:38:46 -0700 In-Reply-To: <1624342161-84389-1-git-send-email-jiapeng.chong@linux.alibaba.com> References: <1624342161-84389-1-git-send-email-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.2 (3.40.2-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-06-22 at 14:09 +0800, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-ENOMEM' to the return value 'err'. > > Eliminate the follow smatch warning: > > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs() > warn: missing error code 'err'. > > Reported-by: Abaci Robot > Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all > firmware steering"). > Signed-off-by: Jiapeng Chong > --- > Changes in v2: >   - For the follow advice: > https://lore.kernel.org/patchwork/patch/1446816/ > Applied to net-next-mlx5 Thanks!