From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9919F38F227; Mon, 9 Mar 2026 22:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095103; cv=none; b=KyquryRFW9a0TSMNmt/9MbWvDZ2+0jrUI8O8dFwl238tNknUxmGZo3vWoIqhncTmfSTTbDw8Lyagb2b0OPdO7uYXRQRjmZeGgB7XrCWq2mKPLz+PGSyHu1hk8m94d4voc9RJKkB0dUvCNyd4ZKxQwE+JhKeIrIhX9NzJCg4BcfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095103; c=relaxed/simple; bh=hckjB5g7I975zcOJXmp99aNgILQkqpDbFrtrSs5y1ss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XQ2gJdt0oswoiJY9nLlRVCx+JIr1R82H5Hs0lalM94KOdmxpw0dcLn6gTR69+W7t5BMK/HPJBDHi89nd53rhSbYHZQxuEZKmGyRNranaAls561bSPTctItw2cWdWIDA8hpiOmdnxz1uFOKDkCxRjQs7zBDDEa61S8iwT479flrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=DNnwbMj8; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="DNnwbMj8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1773095099; bh=hckjB5g7I975zcOJXmp99aNgILQkqpDbFrtrSs5y1ss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DNnwbMj8/YlrOnNot42II5y3J+kOlgf+2d9k8gQbFW8RyvLveEvR8wYqBQQNIPPWb kEsJ2r8b/s/7vm0V2qc0k+wZZDlXBiuOpfdX3L8uRLUcdOTUYhV8THqEjm36QqQmoa cVs14cUf10GuiVi2YmsxnHTgo2ReV3vKTNtHegP4= Date: Mon, 9 Mar 2026 23:24:58 +0100 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Leo Yan Cc: Arnaldo Carvalho de Melo , Ian Rogers , Namhyung Kim , James Clark , Kees Cook , Quentin Monnet , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Adrian Hunter , Masami Hiramatsu , William Breathitt Gray , Barry Song , Qinxin Xia , Bartosz Golaszewski , Kent Gibson , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Andrew Morton , Willy Tarreau , Josh Poimboeuf , Robert Moore , Len Brown , Srinivas Pandruvada , Tejun Heo , David Vernet , Andrea Righi , Changwoo Min , Mark Brown , Steven Rostedt , Gabriele Monaco , Shuah Khan , Jiri Kosina , Benjamin Tissoires , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v3 29/30] selftests/nolibc: Append extra cflags Message-ID: References: <20260308-tools_build_fix_zero_init-v3-0-6477808123b7@arm.com> <20260308-tools_build_fix_zero_init-v3-29-6477808123b7@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260308-tools_build_fix_zero_init-v3-29-6477808123b7@arm.com> Hi Leo, On 2026-03-08 16:46:34+0000, Leo Yan wrote: > Append EXTRA_CFLAGS to CFLAGS so that additional flags can be applied to > the compiler. > > Signed-off-by: Leo Yan > --- > tools/testing/selftests/nolibc/Makefile.nolibc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/nolibc/Makefile.nolibc b/tools/testing/selftests/nolibc/Makefile.nolibc > index f5704193038f7da935d57e0f894970b6e29b78da..e58b2f5eb2b231bb1c194db7365fff7b4e244e5d 100644 > --- a/tools/testing/selftests/nolibc/Makefile.nolibc > +++ b/tools/testing/selftests/nolibc/Makefile.nolibc > @@ -252,6 +252,9 @@ endif > # Modify CFLAGS based on LLVM= > include $(srctree)/tools/scripts/Makefile.include > > +# Append EXTRA_CFLAGS if it is set in tools/scripts/Makefile.include > +CFLAGS += $(EXTRA_CFLAGS) Makefile.nolibc here is completely self-contained. It is not expected to inherit any flags from the regular selftests. So I don't think this makes sense. There is a similar, custom "CFLAGS_EXTRA" variable, which could be aligned, but probably not as part of this series. There is a regular 'Makefile' in this directory which *is* integrated with the regular selftest build system. If you could make sure that it works correctly with what you are doing, that would be great. Thomas > + > REPORT ?= awk '/\[OK\][\r]*$$/{p++} /\[FAIL\][\r]*$$/{if (!f) printf("\n"); f++; print;} /\[SKIPPED\][\r]*$$/{s++} \ > /^Total number of errors:/{done++} \ > END{ printf("\n%3d test(s): %3d passed, %3d skipped, %3d failed => status: ", p+s+f, p, s, f); \ > > -- > 2.34.1 >