From: Randy Dunlap <rdunlap@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: fix map_files test on F29
Date: Sun, 14 Apr 2019 08:24:53 -0700 [thread overview]
Message-ID: <bb2991f8-323a-c835-0b04-ff8d565df0fa@infradead.org> (raw)
In-Reply-To: <20190414123612.GB12971@avx2>
On 4/14/19 5:36 AM, Alexey Dobriyan wrote:
> F29 bans mapping first 64KB even for root making test fail.
so there is an F29-only patch that prevents that?
something that is not in mainline?
thanks.
> Iterate from address 0 until mmap() works.
>
> Gentoo (root):
>
> openat(AT_FDCWD, "/dev/zero", O_RDONLY) = 3
> mmap(NULL, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = 0
>
> Gentoo (non-root):
>
> openat(AT_FDCWD, "/dev/zero", O_RDONLY) = 3
> mmap(NULL, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EPERM (Operation not permitted)
> mmap(0x1000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = 0x1000
>
> F29 (root):
>
> openat(AT_FDCWD, "/dev/zero", O_RDONLY) = 3
> mmap(NULL, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x1000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x2000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x3000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x4000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x5000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x6000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x7000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x8000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x9000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0xa000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0xb000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0xc000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0xd000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0xe000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0xf000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = -1 EACCES (Permission denied)
> mmap(0x10000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED, 3, 0) = 0x10000
>
> Now all proc tests succeed on F29 if run as root, at last!
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> tools/testing/selftests/proc/proc-self-map-files-002.c | 20 ++++++++---------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> --- a/tools/testing/selftests/proc/proc-self-map-files-002.c
> +++ b/tools/testing/selftests/proc/proc-self-map-files-002.c
> @@ -46,12 +46,9 @@ static void fail(const char *fmt, unsigned long a, unsigned long b)
>
> int main(void)
> {
> - const unsigned int PAGE_SIZE = sysconf(_SC_PAGESIZE);
> -#ifdef __arm__
> - unsigned long va = 2 * PAGE_SIZE;
> -#else
> - unsigned long va = 0;
> -#endif
> + const int PAGE_SIZE = sysconf(_SC_PAGESIZE);
> + const unsigned long va_max = 1UL << 32;
> + unsigned long va;
> void *p;
> int fd;
> unsigned long a, b;
> @@ -60,10 +57,13 @@ int main(void)
> if (fd == -1)
> return 1;
>
> - p = mmap((void *)va, PAGE_SIZE, PROT_NONE, MAP_PRIVATE|MAP_FILE|MAP_FIXED, fd, 0);
> - if (p == MAP_FAILED) {
> - if (errno == EPERM)
> - return 4;
> + for (va = 0; va < va_max; va += PAGE_SIZE) {
> + p = mmap((void *)va, PAGE_SIZE, PROT_NONE, MAP_PRIVATE|MAP_FILE|MAP_FIXED, fd, 0);
> + if (p == (void *)va)
> + break;
> + }
> + if (va == va_max) {
> + fprintf(stderr, "error: mmap doesn't like you\n");
> return 1;
> }
>
>
--
~Randy
next prev parent reply other threads:[~2019-04-14 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 12:36 Alexey Dobriyan
2019-04-14 15:24 ` Randy Dunlap [this message]
2019-04-14 15:58 ` Alexey Dobriyan
2019-04-14 16:06 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb2991f8-323a-c835-0b04-ff8d565df0fa@infradead.org \
--to=rdunlap@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®