From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbdFLIaC (ORCPT ); Mon, 12 Jun 2017 04:30:02 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:19688 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbdFLIaA (ORCPT ); Mon, 12 Jun 2017 04:30:00 -0400 Subject: Re: [PATCH] pci: endpoint: fix endpoint test build error To: Randy Dunlap , linux-pci , LKML , Bjorn Helgaas References: <89a5b4f8-69bb-a5bc-5400-06c24050595d@infradead.org> From: Kishon Vijay Abraham I Message-ID: Date: Mon, 12 Jun 2017 13:59:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <89a5b4f8-69bb-a5bc-5400-06c24050595d@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 June 2017 07:40 AM, Randy Dunlap wrote: > From: Randy Dunlap > > PCI endpoint test driver uses crc32_le() so it should select > CRC32. Fixes this build error (when CRC32=m): > > drivers/built-in.o: In function `pci_epf_test_cmd_handler': > pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le' > > Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI). > > Reported-by: kbuild test robot > Signed-off-by: Randy Dunlap > Cc: Kishon Vijay Abraham I > Cc: Bjorn Helgaas Acked-by: Kishon Vijay Abraham I > --- > drivers/pci/endpoint/functions/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig > +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig > @@ -5,6 +5,7 @@ > config PCI_EPF_TEST > tristate "PCI Endpoint Test driver" > depends on PCI_ENDPOINT > + select CRC32 > help > Enable this configuration option to enable the test driver > for PCI Endpoint. > >