mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Joe Perches <joe@perches.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: MAINTAINERS: Wrong ordering in VIRTIO BALLOON
Date: Tue, 12 May 2020 08:38:11 +0200	[thread overview]
Message-ID: <bb2eea77-72df-6c53-5397-de057ffc9dd8@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2005120717260.3701@felia>

On 12.05.20 07:21, Lukas Bulwahn wrote:
> Hi David,
> 
> with your commit 6d6b93b9afd8 ("MAINTAINERS: Add myself as virtio-balloon 
> co-maintainer"), visible on next-20200508, ./scripts/checkpatch.pl -f 
> MAINTAINERS complains:
> 
> WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order
> #17982: FILE: MAINTAINERS:17982:
> +F:	include/uapi/linux/virtio_balloon.h
> +F:	include/linux/balloon_compaction.h
> 
> This is due to wrong ordering of the entries in your submission. If you 
> would like me to send you a patch fixing that, please just let me know.
> 
> It is a recent addition to checkpatch.pl to report ordering problems in 
> MAINTAINERS, so you might have not seen that at submission time.

Thanks for the notification Lukas,

b962ee8622d0 ("checkpatch: additional MAINTAINER section entry ordering
checks") is not in Linus' tree yet AFAIKS.

I can see that 3b50142d8528 ("MAINTAINERS: sort field names for all
entries") is upstream. I do wonder if we should just do another batch
update after the checkpatch patch is upstream instead, I guess more will
pile up?

@mst, joe, what do you prefer?

1. I can resend the original patch.
2. Lukas can send a fixup that we might want to squash.
3. We wait until the checkpatch change goes upstream and to a final
batch update.

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2020-05-12  6:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12  5:21 Lukas Bulwahn
2020-05-12  6:38 ` David Hildenbrand [this message]
2020-05-12 16:23   ` Joe Perches
2020-06-04 19:27     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb2eea77-72df-6c53-5397-de057ffc9dd8@redhat.com \
    --to=david@redhat.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mst@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®