From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Avi Weiss <thnkslprpt@gmail.com>, Bjorn Andersson <andersson@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rpmsg: qcom_smd: release channel OF node on device destruction
Date: Thu, 15 Oct 2026 13:59:31 +0200 [thread overview]
Message-ID: <bb2f2366-2525-468a-961c-41fb81bf2d15@oss.qualcomm.com> (raw)
In-Reply-To: <20261013055642.793161-1-thnkslprpt@gmail.com>
On 10/13/26 7:56 AM, Avi Weiss wrote:
> qcom_smd_match_channel() returns a referenced OF child node,
> which is stored in rpdev->dev.of_node. qcom_smd_release_device()
> frees the device without dropping that reference, leaking it
> when the channel device is released.
>
> Release the OF node reference in the device release callback.
>
> Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
> Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-10-15 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 5:56 Avi Weiss
2026-10-15 11:59 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb2f2366-2525-468a-961c-41fb81bf2d15@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=thnkslprpt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®