From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FEE1C07CB for ; Mon, 10 Feb 2025 08:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739176107; cv=none; b=Iv6BepHtDxqq5T0V2/F2W9MBF577Xb22r2csAt3wcZJ41VEbT0ktmbHMuHjunXP6W2/SKKjkvjoJmjaki7wwQdY2FMSqI0cZTFR4nveQfoi9cTg9Bi2MRYkJl7FbyEU+HT0dZVNcLdoObbyw4zGRYoedQRu1V5VJtMO7UYytDhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739176107; c=relaxed/simple; bh=V5wU/29c7mNYE3/QefZiuSHFC/1Vw5d/10zz4ZCU6wU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N43TqdS9/SyAehxOttHBgK4Q5VVGBeOP8lhmiq75NqG9fpWJTC96qWmjnhHgps9hTWaokBtIiv2p40e1f/y4W234ML4CnJKXkvaoeBO2uBPjKmkEFxWplMNT8gqdO7xSWuz4zQQfaYRs6zUO6beZnpKrzBz9fr8+ehgWO9rDFb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M+YP1i4o; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M+YP1i4o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739176104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bicHG7zjx2UMOO4n8zha5UgWZ2e74X0E23kGVMNRanQ=; b=M+YP1i4ov1YX7VO7QzVXrUeDafkSoLJJxts1lQqabdATlAc+sPwGUs1he2sfHX7lV71PNV soeGAPSFKlD2tp18N94+lNkPNUVAWDSmyO9BdOS7MLWJuxHGV2I43tNp3YQHxyyiZYZyiP PzhdqJCaCloavZCLxQxwmzlDPqzDedc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-CIotmNI0Np-viCqFIUxe8Q-1; Mon, 10 Feb 2025 03:28:22 -0500 X-MC-Unique: CIotmNI0Np-viCqFIUxe8Q-1 X-Mimecast-MFC-AGG-ID: CIotmNI0Np-viCqFIUxe8Q Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4393e89e910so5396315e9.0 for ; Mon, 10 Feb 2025 00:28:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739176101; x=1739780901; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bicHG7zjx2UMOO4n8zha5UgWZ2e74X0E23kGVMNRanQ=; b=SVZFlU5vI0ABxPkv3mqYZuDqPWLf4Gp+NPVGs1yp5PTsKwk9CVcZTjuoVMoNRIi8es 8102P9fDjljL7jbXqzjVNWvfDINDexk4wV6dz/d6PoWMvJDVM3TyuDrDwgLGDgRzPq3C nrp5hQo3SMQ2pm+4wGvez7Vv0JaOHzoXTNYrBY4kxLMvhjCaodxbCfnB16xMaXxHVnaE J8U+ggZtyYgjk711GHhTl0me47OX90YUqeRAh82zhdTFF94VdNIrMqiPrLSdsy51oaPj Qah1Gb3w/CSgW5ZH0Lm3GOsHOWxPM206rZcbuIZxjAVJlerTEVfe7gGE3QqYij6dXTdD BnRQ== X-Forwarded-Encrypted: i=1; AJvYcCXytfW0PmvSMAcRLe/bOojTKB79wRswd9D9eisPPR03NA10HtEt/MTBHX9kAvcs+g+YyYV3W0X6FBEOmmk=@vger.kernel.org X-Gm-Message-State: AOJu0YzN1rixjcmvRKTWWdP45iUmnECsRd4hEE7j2XamGU18Cq6Dtexp A1lZflEKB0lL2cmg74hJZ6X/YL5DRLFh35XfbQtkVdqDUqTn6RRtIBufajJvoXI6vD7k2FCVQCS lllDys3tqkE98N+NQy6f4QNl8ph97S1VeNxqVCcaVqLUrbXMKRnNdDejjyJ8IWw== X-Gm-Gg: ASbGncs+kFUA92Fmz93RVV9LVRY33uldYulGr4KONXZEe+j1w/KfplA77cWSb1y33YV NyU+U5LF5RgqTOLcn5RcXJp12W58fw8PEWIbQfkGRK1CqAw/gfh/rbMX5ogkABErjaL9SRd85hg 8RTcFX7tqM/O+iJfUNFncon2dRgZzbdO5JZsOqYlAYPAP64XzbYSscCjqjzdWNu+pFRT8bJdviR /nqAIS4+EqUJPzvFWpS5O6UNQBOQstShqmixn8QfXfYIUHVpQPy6sV7WXt1fXY5hDD1l2j1xv/5 srPSyHiPgY22jJfpST6KWk+zxBtyo2bxMbGi/hWEGKN/OObiWNeAzxqVHy4lURS5UsVU2D52DfL LIZtnubee7IUCjfNxDaXeBksuboZtTpRh X-Received: by 2002:a05:600c:3c8f:b0:439:3e90:c535 with SMTP id 5b1f17b1804b1-4393e90c71cmr40397965e9.0.1739176101210; Mon, 10 Feb 2025 00:28:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVe5xArCsukLiDpa1Z9D7uo1ruE78+ptabaMmnnCZmgUIOVJ8TIj/+l2P6inhlogLtasPzog== X-Received: by 2002:a05:600c:3c8f:b0:439:3e90:c535 with SMTP id 5b1f17b1804b1-4393e90c71cmr40397635e9.0.1739176100798; Mon, 10 Feb 2025 00:28:20 -0800 (PST) Received: from ?IPV6:2003:cb:c734:b800:12c4:65cd:348a:aee6? (p200300cbc734b80012c465cd348aaee6.dip0.t-ipconnect.de. [2003:cb:c734:b800:12c4:65cd:348a:aee6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd295200asm6517640f8f.44.2025.02.10.00.28.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 00:28:19 -0800 (PST) Message-ID: Date: Mon, 10 Feb 2025 09:28:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: add an API to enable/disable concurrent memory allocation for the CMA To: Barry Song <21cnbao@gmail.com>, Ge Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, baolin.wang@linux.alibaba.com, aisheng.dong@nxp.com, liuzixing@hygon.cn References: <1737717687-16744-1-git-send-email-yangge1116@126.com> <28edc5df-eed5-45b8-ab6d-76e63ef635a9@126.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08.02.25 22:34, Barry Song wrote: > On Sat, Feb 8, 2025 at 9:50 PM Ge Yang wrote: >> >> >> >> 在 2025/1/28 17:58, Barry Song 写道: >>> On Sat, Jan 25, 2025 at 12:21 AM wrote: >>>> >>>> From: yangge >>>> >>>> Commit 60a60e32cf91 ("Revert "mm/cma.c: remove redundant cma_mutex lock"") >>>> simply reverts to the original method of using the cma_mutex to ensure >>>> that alloc_contig_range() runs sequentially. This change was made to avoid >>>> concurrency allocation failures. However, it can negatively impact >>>> performance when concurrent allocation of CMA memory is required. >>> >>> Do we have some data? >> Yes, I will add it in the next version, thanks. >>> >>>> >>>> To address this issue, we could introduce an API for concurrency settings, >>>> allowing users to decide whether their CMA can perform concurrent memory >>>> allocations or not. >>> >>> Who is the intended user of cma_set_concurrency? >> We have some drivers that use cma_set_concurrency(), but they have not >> yet been merged into the mainline. The cma_alloc_mem() function in the >> mainline also supports concurrent allocation of CMA memory. By applying >> this patch, we can also achieve significant performance improvements in >> certain scenarios. I will provide performance data in the next version. >> I also feel it is somewhat >>> unsafe since cma->concurr_alloc is not protected by any locks. >> Ok, thanks. >>> >>> Will a user setting cma->concurr_alloc = 1 encounter the original issue that >>> commit 60a60e32cf91 was attempting to fix? >>> >> Yes, if a user encounters the issue described in commit 60a60e32cf91, >> they will not be able to set cma->concurr_alloc to 1. > > A user who hasn't encountered a problem yet doesn't mean they won't > encounter it; it most likely just means the testing time hasn't been long > enough. > > Is it possible to implement a per-CMA lock or range lock that simultaneously > improves performance and prevents the original issue that commit > 60a60e32cf91 aimed to fix? > > I strongly believe that cma->concurr_alloc is not the right approach. Let's > not waste our time on this kind of hack or workaround. Instead, we should > find a proper fix that remains transparent to users. Fully agreed. IIUC, the problem is that we find a pageblock is already isolated. It might be sufficient to return -EAGAIN in that case from alloc_contig_range_noprof()->start_isolate_page_range() and retry in CMA. ideally, we'd have a way to wait on some event (e.g., any pageblock transitioning from isolated -> !isolated). -- Cheers, David / dhildenb