From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3019138F624 for ; Mon, 16 Mar 2026 10:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656579; cv=none; b=mdgeVjOGO8dGx8TWuNUe2IWlnAi8rfDkBgKViE0QmUdUV+Sf/+2dbJXpDhMg+IPu0vzT504XJbckZEZKVLutL3b3TN9U2pK+Lk4JZI4D2SCL5q5+pjWACBrluzEzB543RIRlVPKn6T5dYwjV1m+Ko1FRfvKr6Lj09MkSdifiKSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656579; c=relaxed/simple; bh=SQVI6k4aCbiCeCNLXIx1I0+fKjm6v1C1tutNaXc+CNA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1Vqx0iL4mrabPh9O41zb02gpochPS7xFna9gdgLTs71EKZz0taszxGq3vf4IjQZFzLvjLUKf3F74tY+Su38ri3zmgRc9AX1T10b8Uu+lZsL6lKxp/odr5Vp5IloHV4UfoU+iysrrTXhrR5RCHg+G+tCiJBzxqqOF32Iuo0f9w4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T+s++aG7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D5lnVTjh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T+s++aG7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D5lnVTjh" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64jVF538903 for ; Mon, 16 Mar 2026 10:22:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mMLVJCkhpdvuaYBZT6ZJtpjc60jL3K/BIc3n5U+wroc=; b=T+s++aG7kI83DMIZ DPR88V5qU3L2BoOYdVP1CJZRrpds/xN4D767MuHpNYkHtVSlToGLTpG/vvAT0LY1 lfgWT9FH0hO0DxciHbzSuM/RNX8BmvahKcBZRUMYOqwUofJDOSR/0SIaebHais96 7AIiMEZ9OyrDDXoO/ZZOX549V8JatK1/D8STEKn2c+L2Ic3DKYKogaD3IRbRzV+U ihbzFG4APTS1vEH/Paeju6KPaDrM/FalwUM85X/W/pbG978Y4AaqxA5AvmGpf+Rj wMi/2vWnZ+HCAvLAtk3oilnvoItjhx1ArV1Of2G6h+cjyInGRC3P4ZwUuQnfEHeo zA6Rlg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvyy5n79a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 10:22:57 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c738563e61eso2626188a12.2 for ; Mon, 16 Mar 2026 03:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773656577; x=1774261377; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mMLVJCkhpdvuaYBZT6ZJtpjc60jL3K/BIc3n5U+wroc=; b=D5lnVTjht8IUNLGjgm+0tullxHXIzjwogu2Rm+5dR3stYCqCSUoM+HLTEL/obYXczW 1TGg+YkFg3HIWOOCkY/jY7EOqQefF3t54Y2+MOipITgmw5AOk2F27ljQhc8+aZN7wo8t rqHn/FbgDALVLt977+k7C0ds/mbzXncN2D5TK6GWI9siVe8VxxK4gB011P/02Lxin3K4 mvJXk1HVha0CU0MNI/an7xWWx661toH1IdCgXdZqan0DLFft/aLaG76RT5/KVyb/WGmW FF7zw3rrUwek1DWa0qdQDQnx0APor9BsrfcrN/I5OoiWqeUvvS2GN33LbNBfSb+1PYLp KQKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773656577; x=1774261377; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mMLVJCkhpdvuaYBZT6ZJtpjc60jL3K/BIc3n5U+wroc=; b=Am5vKb6W8GF+frMU+tdGFBeawGj0zIPhKOir8TVn1p/7AMOhik8ab9vyohE6xddEMQ YE/zVvvE86T+5C7GSHeeRPORItaVSVs/SrmgHAGTQTrwQL4y0pVqSePw58nxoUngDEQ+ nD7czxK2bzAjLFR7iAvrUDIdaRM6HTxqk3dApkmya2qkJdDys+LuBxbMvqwftHrjHk9p WFxhVU3kkIJOVQTPY2UV5VisHnJTKGg0jYx5F5+tnMC3DDiS1ZhjP8qkXselB5UwHVI/ ogm4YOrXNvaBr0bVTLCZElqv07rgILnId4VROckm3y5IlllZ17DtZbdwHAX6vMcruyCH bz+g== X-Forwarded-Encrypted: i=1; AJvYcCVvDT8SGr9D5dfXd+DX1UXS0TMXSTO1plW47Y0YVxRnmoAWkCPbCz+aa19kANYwgItREuX81u2ygCJDNWU=@vger.kernel.org X-Gm-Message-State: AOJu0YyMdHxvxZTyK1kMR43ecPtO0iOox4MAfIXJlGabWT9bwvrMfM07 lLkE2QiC3/wMx04ZlagP8yfhePwzO+vnWv6PLWjIKWFhC0xCHBLEmvVPx7MjDQU8kuabj8CuWRu KPfv0qHdrxOjshfoScXGs+LR7piD5+xQUiRuaBZuVM1l7vbFbXSND6nWDuqapVscEA5A= X-Gm-Gg: ATEYQzzdGjqKF2xr16n7CtYhsJ1WYcu+pNRQ9DFMAdnYicDFhxzEWvSC4FxOZzsUDJs UIwwk92rd7kR+mhKwF25SnZVYMDAMP91IcqwAJZcVnQ2skWS1++UNlBwJ3IqveWJHM2g1Y3yBCy J2ncGtcv9veNFU1Rm2zR9MmqxOGx4gPQXteoKEbc5qTIR1X+SdPeZ3r/GJeRug5/sOH3Wet4GeN 7NZeY77ystldKpdt4kzl7Ih0NNOxjVEyWkL4znqOdz8E1GecFb1kcb6EhZR1XxARdpf+omrE7tB 4Bt9RT+Ee9GZ54J4Eou6w0yEd1r3ipsfiC1b7ugYMsBSGtWbRvSuVW/e8pqIGNw73p2MqyyTSJp 31rW5MBoIKpKOjcCWEwtyfo5D7Padi7lYmYHJX7xvPO9pZ048N8OsAqyuI3fXpfPBO9ClIyNw5o aJUp3G865a5Pb992Vqr94PCARBS+awpbTBmQ== X-Received: by 2002:a05:6a00:2d90:b0:7fb:f87d:a0aa with SMTP id d2e1a72fcca58-82a19916342mr11124624b3a.52.1773656576769; Mon, 16 Mar 2026 03:22:56 -0700 (PDT) X-Received: by 2002:a05:6a00:2d90:b0:7fb:f87d:a0aa with SMTP id d2e1a72fcca58-82a19916342mr11124592b3a.52.1773656576284; Mon, 16 Mar 2026 03:22:56 -0700 (PDT) Received: from [10.79.197.144] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07244071sm13441253b3a.6.2026.03.16.03.22.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:22:55 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 15:52:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] Add driver for EC found on Qualcomm reference devices To: Bryan O'Donoghue , Dmitry Baryshkov Cc: Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <132116be-2964-4b98-be2b-1baae5bfb58e@linaro.org> <19e8837b-d711-4d0e-ba9c-e9b2c8330969@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: cM_04zV2kqh-5YSaqU5q9FLfjwHq-W3e X-Authority-Analysis: v=2.4 cv=QOxlhwLL c=1 sm=1 tr=0 ts=69b7da01 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=meSk0gseeHhLLlbLLrwA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: cM_04zV2kqh-5YSaqU5q9FLfjwHq-W3e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA3OSBTYWx0ZWRfX8mwC9ZGbBxQS Y+ZVy9wHgIlxb1OHfmfNd/XuaUV1di6/ES58I2oEUAPwtXwJRYH+9KpgRK1OGOj5qM5us+K+eUC ceHuBGb5XgKXC2RZtPBL13bTgvZ4rcUjhJwCUrcNCt3Zt5kKC3jSoz8GDZ5ba9EIAlFI7XBLBPh PmCD3zVHekfcUX2xDZB3X9ipZ7TFCY7i/cIJ89pxH1q+xhmQvQRO2vKoXzlzb3ikK2YclnFR+D1 n/l17/T0cwl4fnWRWWisi71T+ECR/pDf/w8HiB8yEodv9LIQIwlmBC2rvdHtoUP0xRWWGc0AZaI gKzDL5rvAJ4TmoklX9NsK0gdnd3D1mzi9EBZihSO3ENr4UtNOSwLnMKWW+YTiH+tSQ9AxqRnvHt ZiT6qFcNJ0lMkP1YSeYZD18K+ScbTe0zJsHLhGiuavf3QD2n62EmlF9C/QeYJrU2DTRVY0NeqS+ RiBCCyb3GTkoJ+AIMmg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160079 On 3/14/2026 9:39 AM, Bryan O'Donoghue wrote: > On 13/03/2026 17:17, Dmitry Baryshkov wrote: >>> Fan Count == 0 || Thermistor == 0 => error and probe() fail. >> WHy? EC is still there. QUite useless though. > > You want to register when zero fans are found, zero thermistors... ? > > That's a bit fruity. > We need to keep the driver loaded even if zero fans are reported, as it is also responsible for sending suspend/resume notifications to the EC. Failing the probe would prevent these PM notifications from reaching the EC. Instead, I will add a dev_warn message suggesting a firmware upgrade when zero fans are found. Let me know your thoughts. > --- > bod -- Best Regards, Anvesh