From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=113.46.200.218 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795253942; b=Mu/ydcWkW7ZoyrNidb0MNjDwWZrO6pmqIGtkWe+2PkLqVgGJ07a2heirGzmHyWiG8uyU idLfw3eTdE6OGo3xEP20cgdCY82mJg0/2ZlK88wQIGpj18b0cBURzvqNJCpZ1MzeJoQqC F+OPirtqJy4fHq63Wg4qUVasxrki1cscvl/atCmam17yePny3zQXhoh0XHClyhbUBWGb3 tEsrXuQFt+wZf72opUZcRPIrMhAyN3DbG6HzvbPDFYGHPJOcGrJhP52axHb6acqxYICIf Ix3fvJ2S+GAU1eDowzNX3WN/khuEb1v3Y49YB5HEThZzpyiGMeaq16z5gHDtSxuaufQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795253942; h=DMARC-Filter:dkim-signature:Received:Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:CC:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Originating-IP: X-ClientProxiedBy; bh=onii5ZHNX8GZAZk6MiQXB1RSU4RcSBt2Z/EMxgNhA0U=; b=l9vf8W4gwODU1ENhBl185/ZvDafh+KKlcEu4Xmfpv/ft2di5OPpUXFqEXporYCMoQ4XR e64TH07In4CHAXOI2LWTQWIZOqC7D1x1yup4jEeN17Mt/3FBV9D273YZS+YJKb3qvPpYy gAxNVVVd9RYdjX9aDxDowYVUZlUWRa3c73ImloP5DEj1TfHXvtbQLA9UxK75SxyyJd+b9 Jev4CmvBPPvICqoZ/z/O4puGwndGRIu6LcGe6/pucEQ6al6y/p42LTIqwHV2ZZfT3iMi2 N75h4SwOATknPKBy2OpsrHK/AwUfh4vdDsOHIOOYD/yLuOlWcDKpJySiH/+N3JhssNQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=L1rdHUey; arc=none smtp.remote-ip=113.46.200.218 Received: from canpmsgout03.his.huawei.com (canpmsgout03.his.huawei.com [113.46.200.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8198606A320 for ; Sat, 21 Nov 2026 09:39:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C8198606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=L1rdHUey dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=onii5ZHNX8GZAZk6MiQXB1RSU4RcSBt2Z/EMxgNhA0U=; b=L1rdHUeyLtCwunnNOYXmGJHWInoGMx5AjlFixjf1M7l4Az3X4RlwecRipLRlW8qE7XVbH0dUI sD7v/Im6yj0FF3UO3fTtCUDc4uECd5o21m7fJYJSerXyHLhe8nd+42uhVhRgEHxVC5moQDEs821 c0X8NaPbJ1F+vMZXP+H+7Zo= Received: from mail.maildlp.com (unknown [172.19.163.0]) by canpmsgout03.his.huawei.com (SkyGuard) with ESMTPS id 4jWnF46y6pzpSvf; Sat, 21 Nov 2026 17:38:00 +0800 (CST) Received: from kwepemk200005.china.huawei.com (unknown [7.202.194.71]) by mail.maildlp.com (Postfix) with ESMTPS id 3C54F4057A; Sat, 21 Nov 2026 17:38:56 +0800 (CST) Received: from [10.159.167.44] (10.159.167.44) by kwepemk200005.china.huawei.com (7.202.194.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Sat, 21 Nov 2026 17:38:55 +0800 Message-ID: Date: Sat, 21 Nov 2026 17:38:53 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for drm-misc-fixes v5 0/2] Fix some bugs in the hibmc DP To: Thomas Zimmermann , "dmitry.baryshkov@oss.qualcomm.com" , "tiantao (H)" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "daniel@ffwll.ch" , "kongxinwei (A)" CC: "Liangjian(Jim,Kunpeng Solution Development Dept)" , "Shuliubin(Turing&Kunpeng)" , Chenjianmin , "helin (T)" , "shenjian (K)" , shaojijie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , References: <20261117130056.272609-1-shiyongbang@huawei.com> <5418426d-2dfc-4dbe-a74c-47275c1fbbc0@suse.de> From: Yongbang Shi In-Reply-To: <5418426d-2dfc-4dbe-a74c-47275c1fbbc0@suse.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemk200005.china.huawei.com (7.202.194.71) > Hi > > Am 17.11.26 um 14:00 schrieb Yongbang Shi: >> From: Lin He >> >> Fix some bugs in the hibmc DP driver. > > I can't really comment on the hardware details, so > > Acked-by: Thomas Zimmermann > > for the patch set. Please see my comments on using lock guards before > merging the series. > Thanks for the Acked-by. I'll fix the lock-guard usage as commented and send a v6 before merging. Thanks, Yongbang > Best regards > Thomas > >> >> --- >> ChangeLog: >> v4 -> v5: >> - Invalidate the link in the hardirq when an unplug is sampled, and >> stop clearing the latched HPD status in hibmc_dp_hpd_cfg(). >> (sashiko-bot) >> - Serialize a whole AUX transfer with hibmc_dp_hpd_cfg(). >> (sashiko-bot) >> - Append HIBMC_HPD_UNKNOWN to the enum instead of prepending it, so >> the existing HIBMC_HPD_OUT/HIBMC_HPD_IN values do not change. >> - Only set the enable flag when DP was initialized, clear it only when >> it was set, and do not request the DP interrupt if DP initialization >> failed. (sashiko-bot) >> v3 -> v4: >> - Fix the data race on hpd_status between hardirq and process >> contexts with WRITE_ONCE()/READ_ONCE(). (sashiko-bot) >> - Delete the HPD_IN early return in encoder_enable that breaks KMS >> forced modesets. (sashiko-bot) >> v2 -> v3: >> - Delete irq_status and use hpd_status directly for hotplug >> detection. (sashiko-bot) >> - Add debug logs when hpd_status is not HPD_IN in detect and >> encoder_enable. >> - Move hibmc_set_enable_flag() before drm_dev_register() and >> hibmc_set_disable_flag() after drm_dev_unregister() to narrow the >> race window. (sashiko-bot) >> - Add spinlock_t gpio_lock to hibmc_drm_private to protect all >> operations on 0x0802A4. (sashiko-bot) >> v1 -> v2: >> - More states in HIBMC_DP_HPD_STATUS are added to the >> 'hibmc_dp_get_hpd_status'. >> - The call to `hibmc_set_enable_flag()` has been moved before >> `drm_client_setup()`, specifically before the connector detection >> triggers the I2C bit operation. (sashiko-bot) >> - A read-modify-write operation has been implemented instead of directly >> writing to prevent clearing the I2C mask bits. (sashiko-bot) >> --- >> >> Lin He (2): >> drm/hisilicon/hibmc: Modify the method of obtaining the hpd_status >> drm/hisilicon/hibmc: Add a flag to indicate whether the OS-side driver >> has been loaded >> >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 11 +++- >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 2 +- >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 40 +++++++++----- >> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 6 ++- >> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 32 +++++------ >> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 54 +++++++++++++++++-- >> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 + >> .../gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 19 +++++-- >> .../gpu/drm/hisilicon/hibmc/hibmc_drm_regs.h | 3 ++ >> 9 files changed, 129 insertions(+), 40 deletions(-) >> >