From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795264968; b=BXxr+JMiAL8SIncZbRiQipItjUfrfS058PVcyjJ2Bc/1KfHUmdxIUh4vdEsu0Pki22Ld OwoK+si98IudZy/3mLmnVyCGlnyU53tt1BcggU3CIGW7BeO40f3JDY0s/nGJXTkr4cYV6 C947B3exSFRTqvZ9R9T1/WWhKpJOj/W0tiqiHP4dpWDZ2CsxPP5bHVcQf3P3LZ+b73+Id IZMSfOlXQdePwmuFJilrRCVNFW3HCLj0/zUc5i5K6oq0iaaFFyK0nOBMvb011fHlC/t+j qRWMMqnZTZGTXFt/EE1RxmfgI03E0CD3npFcyiMp8j6Ti5A2MFWrEt5s0+2yM45Lx1g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795264968; h=Received:DKIM-Signature:Received:Received:X-ME-Sender: X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:X-Mailer: MIME-Version:X-ThreadId:Date:From:To:Cc:Message-Id:In-Reply-To: References:Subject:Content-Type:Content-Transfer-Encoding; bh=RuNf+pePjIWf7fpgOl6kHLwN5HRwrqk6Ttj5H6K8/Jo=; b=edwN9lGnY5HskDnsysl0Oi5NF+8ZFU2VQV5fxDCC5wAvw9krVGtwuKaE1Z4zXvfcfK9S qV1dfTUh3N8LrIYeVmLbSIHEDLG+G8Chy70U1AGWkv+VEjihW85TdrCM/aSt1kMJ+U37k NZXN4xCUyupQMLsRYOahphIyVMxx2OX4uqBbwpWZ9tKvV6Y3dkAbbQsssTyUiuKFDBep8 o6mBRLT6YZvG04r0TXjTqXhWi+QF38KZtLDU4X/Fw+h05vsMzaUrK05Vp8tlT1aJkcolz 8qO2YlM/IolCQapjGYCYvc5TTFq4gUyAlol8zzoaJhk1jrnvFW//4Kt8ikh/14Z/CgQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Edkrk0u9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B173606A320; Sat, 21 Nov 2026 12:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Edkrk0u9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 494501F000C6; Sat, 21 Nov 2026 12:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795264967; bh=RuNf+pePjIWf7fpgOl6kHLwN5HRwrqk6Ttj5H6K8/Jo=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=Edkrk0u9ZBtn+sfvtyuaB/62cjo0kHZXc7JqL1+Jp4ysmhyM/WQWc+zX5yq5ntE+k PL91l3Ay41tESI8Ugjuvp2aENCO0yodQ5+tfIZLAi13ySYtAfEaVGuxx1E57xfWmis rEjsgGfnti4RQFMyOPd3QkzDs7JG5bd3LCiGn1+JSoIMwFGbjkMTaJam9jZPEqhKs9 OQyjCnUOo+vaApoK20oxvbEZpoqIssyd7YG2tavubLveNtDjejhWiRSqVmCOp1ucF2 q3YhaEZbxEysEJktsEXJmYai7zYBPzNQdPoOqVpcfVvZGgxERveq0jA9pmSyw/uW2I ilbvM8oWL2z4A== Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id 8364D198003A; Sat, 21 Nov 2026 07:42:44 -0500 (EST) Received: from ams-imap-11 ([10.64.2.31]) by ams-compute-02.internal (MEProxy); Sat, 21 Nov 2026 07:42:44 -0500 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTE9e/DNRSP39ywX8YGfN8UoAyYP0CkDVl1avqiAO6xwU1q4JAb9xbXdWO/PpICXkX zSe7F6+aKSXIivBTl4vZebp345mjcvLiZD9TrcN4QHwBOm4LthXKqGLtvIk6OB86Itx5kS d/UV1jGeDDUTrmqovg7yftxuaJvfmdlHv1cqtQRmHAiOgfntYjw8a9G5ML3j1HE+rNqrVv sJFYZ4GZgtsNvuRQjxcJtW6yVD0Woj3jL7EuAHCN2PhP3rLmluqpBpD3npZIKTrh/eJwu+ Lw3q/JjeWsgRzz3r5esxoF6oGSF9wTLqWumVmdUFgjUGa9Tpovw5aSjfTMwfCS592JTuoV OcXXV3oeikv72LVep537lddmHM1Iut790jkACgOjIl+lEFO4p3xtlcZddXdPlBYFtphFDP jV32RIJDx4tRZ2V5R/L0EsrklNVJbzl7ijr/T3nZVrJa82J4FoSmDH/wqpWF6Q/DzLC7UO 0GqxSPyYwOx8njcf0bDlwbbQQrKhDvHIkwvEcARRI/kQBu4gR7VcNwPUgpi5Vo+mq2sbbX JsQXlL0ca+cqLynAiw8kIttg+OZmMDY42RhkY/ihzW1I+bJk+G9+JyYVViCb3eNHh6SNs7 Nga9lB9eHPZJC2iV/xvblxvv98by0fJIDxf0P1vn//Dnp0e2VImQzs8lz2wA X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id B33E7F8008E; Sat, 21 Nov 2026 07:42:40 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-ThreadId: Afc6hXNcC8eV Date: Sat, 21 Nov 2026 13:42:20 +0100 From: "Ard Biesheuvel" To: gaohan@iscas.ac.cn, "Ilias Apalodimas" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Atish Patra" , "Stephen Boyd" , "Brian Masney" , "Jerome Brunet" , "Chen Wang" , "Inochi Amaoto" Cc: "Han Gao" , linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, sophgo@lists.linux.dev Message-Id: In-Reply-To: <20261121-b4-sg2042-efi-rtc-v1-1-19898b8ad497@iscas.ac.cn> References: <20261121-b4-sg2042-efi-rtc-v1-0-19898b8ad497@iscas.ac.cn> <20261121-b4-sg2042-efi-rtc-v1-1-19898b8ad497@iscas.ac.cn> Subject: Re: [PATCH 1/2] riscv: efi: Map runtime MMIO with device attributes Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sat, 21 Nov 2026, at 11:38, Han Gao via B4 Relay wrote: > From: Han Gao > > EFI_MEMORY_MAPPED_IO regions are mapped with PAGE_KERNEL, so device > registers end up mapped as normal memory. > > On Milk-V Pioneer, GetTime() reads the clock controller registers and > faults: > > Oops - load access fault [#1] > Workqueue: efi_runtime efi_call_rts > status: 0000000200000120 badaddr: 0000007030012000 cause: 0000000000000005 > > Use PAGE_KERNEL_IO for these regions. > > Fixes: b91540d52a08 ("RISC-V: Add EFI runtime services") > Signed-off-by: Han Gao > --- > arch/riscv/kernel/efi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Ard Biesheuvel I can take this as a fix via the EFI tree if you like. > diff --git a/arch/riscv/kernel/efi.c b/arch/riscv/kernel/efi.c > index 2d3cc57b4535..11e85d0ebc91 100644 > --- a/arch/riscv/kernel/efi.c > +++ b/arch/riscv/kernel/efi.c > @@ -22,7 +22,7 @@ static __init pgprot_t > efimem_to_pgprot_map(efi_memory_desc_t *md) > u32 type = md->type; > > if (type == EFI_MEMORY_MAPPED_IO) > - return PAGE_KERNEL; > + return PAGE_KERNEL_IO; > > /* R-- */ > if ((attr & (EFI_MEMORY_XP | EFI_MEMORY_RO)) == > > -- > 2.55.0