From: Andrew Lunn <andrew@lunn.ch>
To: javen <javen_xu@realsil.com.cn>
Cc: hkallweit1@gmail.com, nic_swsd@realtek.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
maxime.chevallier@bootlin.com, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel@makrotopia.org, linux@armlinux.org.uk,
enelsonmoore@gmail.com, daniel@thingy.jp
Subject: Re: [PATCH net-next v7 3/7] r8169: add support for phylink
Date: Thu, 23 Jul 2026 03:04:37 +0200 [thread overview]
Message-ID: <bb3be7c9-2f7f-4871-9b3c-bc5958cdb6d6@lunn.ch> (raw)
In-Reply-To: <20260722022906.271-4-javen_xu@realsil.com.cn>
> + if (jumbo_before != jumbo_after) {
> + unsigned long caps = tp->phylink_config.mac_capabilities;
> +
> + if (jumbo_after)
> + caps &= ~(MAC_SYM_PAUSE | MAC_ASYM_PAUSE);
> + else
> + caps |= (MAC_SYM_PAUSE | MAC_ASYM_PAUSE);
> +
> + phylink_update_mac_pause_capabilities(tp->phylink, caps);
The name suggests it only changes pause. So i would expect the caps
parameter passed here to only cover MAC_SYM_PAUSE & MAC_ASYM_PAUSE. So
i don't see a need to look at tp->phylink_config.mac_capabilities.
Andrew
next prev parent reply other threads:[~2026-07-23 1:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 2:28 [PATCH net-next v7 0/7] " javen
2026-07-22 2:29 ` [PATCH net-next v7 1/7] r8169: add speed in private struct javen
2026-07-22 2:29 ` [PATCH net-next v7 2/7] net: phy: phylink: add helper to modify pause javen
2026-07-23 0:57 ` Andrew Lunn
2026-07-23 2:50 ` Javen
2026-07-23 12:47 ` Andrew Lunn
2026-07-22 2:29 ` [PATCH net-next v7 3/7] r8169: add support for phylink javen
2026-07-23 1:04 ` Andrew Lunn [this message]
2026-07-23 3:05 ` Javen
2026-07-22 2:29 ` [PATCH net-next v7 4/7] r8169: add support for RTL8116af javen
2026-07-23 1:13 ` Andrew Lunn
2026-07-23 3:21 ` Javen
2026-07-23 12:54 ` Andrew Lunn
2026-07-24 1:44 ` Javen
2026-07-28 6:18 ` Javen
2026-07-22 2:29 ` [PATCH net-next v7 5/7] r8169: add support for RTL8127atf javen
2026-07-22 2:29 ` [PATCH net-next v7 6/7] r8169: add ltr support for RTL8117 series javen
2026-07-22 2:29 ` [PATCH net-next v7 7/7] r8169: fix RTL8116af can not enter s0idle and c10 javen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb3be7c9-2f7f-4871-9b3c-bc5958cdb6d6@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=daniel@thingy.jp \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=javen_xu@realsil.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®