From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B39734D90C for ; Tue, 16 Jun 2026 14:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781618853; cv=none; b=d7JD6GMerfP3tD1HMUM7lNpwJ8nG317+YEeRzkNsXUaqgEuz27DUdKYhHpsBXEI2R/SMsgkbqEbYx6cRwgOL6T3+R2qTEcf1MWdyEkfvUFqow0OlfT3KaOXDQOgbRZrC+j3Cz+bwN3y8G6te9uaCrylH80rpEgCkOapMog2C804= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781618853; c=relaxed/simple; bh=fWNdGAKn0Vg9If9U/WR3XdW1WMUX1D/WI/n7ACplOXo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fq943MqdHHGS/n9lHvdCOEY2CRhxwnX2ufazX7AbLlE/gaIJoAkOLbvuquwZLQEQEiuAvCEk17WDJ4fs/KM+T65i/sVv9C/gybm/J8CIp/eTqvg6V3gWXK5qxi2B+Blqh4MurRq+aPEj7jHMnErSHTwgK3mCElVWNjsxVoksxxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LxiH0pyD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ABKA10JP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LxiH0pyD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ABKA10JP" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GE079x3314844 for ; Tue, 16 Jun 2026 14:07:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KNoWQH1x3DXp4pJU5DWF9FFhRF/80Xvj4WBq0B37bzI=; b=LxiH0pyDHECyrTt1 Vf5/mls2Nuf5cmJaAZXsNYZo32J7/DP0FCRofiOsxh8qUQX9lauUnN33jQ5QBWBK ct6lUdqW5tjE8vt2hNRKNAOu7Ue1xErQtxxUl13dJG9aLolSwcGaG2vlSieVyjX1 jg/Q2YoC4x1TF8Atsz54lNn7KJB0zl7//yliFTOwcL/kQEbJAfuoY2se9peRK2nQ p7M8iMbk55aYH5qBMqYfRbbnc/gDIcRyo37M8vVQqVbMn9oiOwTtbNQP3gRizEYA Chleu/AEjI/v8Z2gHKxhtN6+UiZyOkj49QTeEDbit//RAQzjvlQMr7xtfx88yq1f YPTaZg== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu0a7t90b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 14:07:31 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-966d2895042so13855241.2 for ; Tue, 16 Jun 2026 07:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781618851; x=1782223651; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KNoWQH1x3DXp4pJU5DWF9FFhRF/80Xvj4WBq0B37bzI=; b=ABKA10JPsKlG+c6gkVtKI0sgzTnIQ451GHjDn00oc79uLO3Ppz15KxR5VzdqxErdMz 8+Nzn2I8Wfr6z1H0N5dYcAiCqn5f5lPwW9aJ1f+JltY9i2FxvCPyMHFDnyhlBPIUdArv eDqIKxc6dhmnOGwXQPoV5+pIvkIXBLIjH8uwkjPE3GXz1gcWiIPfIRM5BFIj4DXpRxQM 31++21Ee39PPr9LExo2pz8Lb9zg2ymWdRhYxDcqMsiTRFbUcLiSHnTC6PtD4byt9abuT Mswbv8X6R//AJg16mPXIkcQuTd7teaA+kiGGvd2Y2NC4AllTrkTStSuBVYPm0ABIvzcD 8yNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781618851; x=1782223651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KNoWQH1x3DXp4pJU5DWF9FFhRF/80Xvj4WBq0B37bzI=; b=hjsxE1asS7UyrLxUmdmN/mV6RjyvMZKXbygy+wLZkIZG5pTWsuWxAd2Ot04u91HrFB +ctbvMLPp+VYklgvDmyl7MNS8Kx2tzQLudbo4fn3pSzl9k23rV7kiYr9Tg2Qzhthcscj xkes+TlFCtxyUtVhMuvJnsDlEJGCldnpNEOIDYBARPvFGYbzc9b1F3YBz6ADWRHF5hxu ZUVh1OYrG0MFBInepSob6/M1rwU/bkyYMPGkh9+aEwTQDoeQJ7V//IDgnXUWWMobdN0R qaPmaAQWb/xGx1XurT9tV9PhEL6JbpCbMBnEEy+irmKI9Wz8X4AurOmL/tUt10e1q834 yJVA== X-Forwarded-Encrypted: i=1; AFNElJ8GWHnt3UNOvtCv3YRzZ7gK1ssBbfT4QfeucgdMdtQDQ8YE7DJo+Zhv4jiCedbJap48zgBWfvcw1e0aFOc=@vger.kernel.org X-Gm-Message-State: AOJu0YwTfng/LMsxEoCkLOUCLvlQZMiGFO1RRS0P7Ew3vami/9BUl6mq SvtTgWPvM0HCHQdjVYLHbsyys6M9Hgq7QkGBSqkkzBWw0rWIO2k3Y8SRK/4h0+2f8sSbgDAeH9v yKYTjw+Ek4Nw9/h6B6UxAda/jzUQ39orAYEjEprl1aJAVKdgvaP3d95GaEz2FXEZJq/MWT3Th5Y k= X-Gm-Gg: Acq92OEcwpCd376HUWFvlTWHINSHY16wvgC5FIy0WeogpyZu5RIGMeUYrj3k+Auwc1P YIdTmRiiDcLomN+BWN8TPWWVs+OsxL0ACFKlCaVxpdGRnt46zPVHV7d+B8wm79mXG+4eXoKTiXL US+/digOBjtovGkZAv6gimlHbBZNtP/9NfO+maR4ZodP64X2THSzWn4ZjadZ3qIJqYJlxLMq/gB mtV80q9rU3ySCgpQUeep+yq6aSX6EMO9DR1hv5FouBOPWAKnOx5ELZidNjYf1ASjWSQm/zy/ARS Bi2w2t4tDyHMJsxQ6c0qF8Vs3y/U4J60QJ+F1Lfdvoud0Oj+7mJyCfulfJ199i0mFOfT7MuywMR dD4q7hv5mkJn6g1zOAsotXMqvhEPgDTRr3Pd71OAzY/CwTQ== X-Received: by 2002:a05:6102:61d4:b0:71f:856f:536f with SMTP id ada2fe7eead31-71f856f5b53mr991015137.0.1781618850884; Tue, 16 Jun 2026 07:07:30 -0700 (PDT) X-Received: by 2002:a05:6102:61d4:b0:71f:856f:536f with SMTP id ada2fe7eead31-71f856f5b53mr990988137.0.1781618850430; Tue, 16 Jun 2026 07:07:30 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6937948dff8sm5199455a12.22.2026.06.16.07.07.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 07:07:29 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 16:07:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v4 2/9] dt-bindings: phy: qcom-qmp: Add PHY selector and Glymur link-mode macros To: Qiang Yu , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260518-link_mode_0519-v4-0-269cd73cc5d1@oss.qualcomm.com> <20260518-link_mode_0519-v4-2-269cd73cc5d1@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260518-link_mode_0519-v4-2-269cd73cc5d1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDE0MyBTYWx0ZWRfX4VMie40mBYRv 0S9bJo15cdU7LcX4tOdZ8juJUN7FynK9CPblDRGmhp2lGRk7SXcfQNAueX8IyxEAQsMkko3isSb c+RXieDOZveaWl7VQQOu0JMw6qWfjXDYw4jLvhQElU5aqJlTtknvcTDhWOxeIckNyIXc+BC1oaj gXl8uEPtLhv+Ne/u+/p+y+n2kfNDHAcHkTTkFl32Ovdf7Q6H/JyN507k3nZ6RtNXUDYC4vr/XMe Lf5yhVJxAaclcHvTSH3RIHhTw4KQZHJzRSl4M4CzIMQ5+5eXP7m2hRI9m8zrPARLlH+9hkFQsFf MI/9XOAElHjcUikYNFomWy0dtINLaZJv+5kNkX6DwQg2sthJeAH5dD4/Xil3F+aMxAjN70EHq0/ 5JvQx8mOWsjgC+4AdYuRAnlT/22i1zOTa/lC1mgQmzP+pAJYBk4NQP7mwrPc/sED7q6CKvrXfAn 7cBkzjbzDb4qeNBs9+g== X-Authority-Analysis: v=2.4 cv=JKALdcKb c=1 sm=1 tr=0 ts=6a3158a3 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=B5XY--lqvWkliBBd-v4A:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-ORIG-GUID: iBFMrHrqT5c5VVjzaCNT8OIDNoIiSWe6 X-Proofpoint-GUID: iBFMrHrqT5c5VVjzaCNT8OIDNoIiSWe6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDE0MyBTYWx0ZWRfX0S7hhgQjp0Ge PkaMnApQB96gG3EmU6BZ6nk871WAhYLVfrbfU7OajJNMR7EzVQuTMl8YADy0ndhlohpm3bKkdqy tJ3xSGrmT/w3SwXlJkjwfojznPyoYZg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160143 On 5/19/26 7:47 AM, Qiang Yu wrote: > Add two sets of constants to phy-qcom-qmp.h to support upcoming multiple > link mode QMP PHY: > > - QMP_PHY_SELECTOR_0 / QMP_PHY_SELECTOR_1: generic logical PHY index > values for QMP providers that expose multiple PHY instances under a > single DT node (i.e. #phy-cells = <1>). > > - QMP_PCIE_GLYMUR_MODE_X8 / QMP_PCIE_GLYMUR_MODE_X4X4: link-mode > values for the Glymur Gen5x8 PCIe PHY "qcom,link-mode" syscon property, > selecting between the x8 single-PHY and x4+x4 dual-PHY topologies. > > Signed-off-by: Qiang Yu > --- > include/dt-bindings/phy/phy-qcom-qmp.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/dt-bindings/phy/phy-qcom-qmp.h b/include/dt-bindings/phy/phy-qcom-qmp.h > index 6b43ea9e0051..befa76f8392f 100644 > --- a/include/dt-bindings/phy/phy-qcom-qmp.h > +++ b/include/dt-bindings/phy/phy-qcom-qmp.h > @@ -21,4 +21,12 @@ > #define QMP_PCIE_PIPE_CLK 0 > #define QMP_PCIE_PHY_AUX_CLK 1 > > +/* Generic QMP logical PHY selectors */ > +#define QMP_PHY_SELECTOR_0 0 > +#define QMP_PHY_SELECTOR_1 1 Is this for the second phy cell? FWIW I think it's fine to use raw numbers as they're just indices (i.e. "nth bifurcated phy") anyway Konrad