Re: [PATCH 2/2] ASoC: Adds support for TAS575x to the pcm512x driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Thu, Sep 07, 2023 at 06:21:50PM +0200, Joerg Schambacher wrote:

> And yes, we cannot be sure that future devices may require different
> settings, but I can hardly imagine anything completely different than
> this approach with the usual audio MCLK frequencies.

They may for example be restricted and just not the the incoming MCLK
divider, or require a higher frequency for some fancy processing.  In
any case tas_device is just an obviously bad name here - there should be
a flag per quirk, not a flag per entire class of devices.

> > This is probably a separate quirk?  I'm a bit concerned about what's
> > turning the PLL off here...

> The PLL should not be used in this specific case where all divisions are
> just divide-by-2's. Your original code does reflect that and turns the
> PLL off. It improves jitter and finally audio performance.

> But in the case of the TAS-devices we even then need the PLL to
> drive the AMP clocks.

That's definitely a separate quirk, and does sound like it should be
driven from the bias management or DAPM more than hw_params.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]