From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005DBC2D0A3 for ; Fri, 6 Nov 2020 11:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89E8B20679 for ; Fri, 6 Nov 2020 11:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbgKFL1d (ORCPT ); Fri, 6 Nov 2020 06:27:33 -0500 Received: from foss.arm.com ([217.140.110.172]:35822 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgKFL1d (ORCPT ); Fri, 6 Nov 2020 06:27:33 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCDD2147A; Fri, 6 Nov 2020 03:27:32 -0800 (PST) Received: from [10.57.54.223] (unknown [10.57.54.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A5B13F719; Fri, 6 Nov 2020 03:27:31 -0800 (PST) Subject: Re: [PATCH] arm64: dts: rockchip: Reorder LED triggers from mmc devices on rk3399-roc-pc. To: Johan Jonker , Markus Reichl , linux-rockchip@lists.infradead.org, Rob Herring , Heiko Stuebner Cc: dianders@chromium.org, wens@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20201104192933.1001-1-m.reichl@fivetechno.de> From: Robin Murphy Message-ID: Date: Fri, 6 Nov 2020 11:27:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-06 10:29, Johan Jonker wrote: > Hi Markus, > > On 11/4/20 8:29 PM, Markus Reichl wrote: >> After patch [1] SD-card becomes mmc1 and eMMC becomes mmc2. >> Correct trigger of LEDs accordingly. >> >> [1] >> https://patchwork.kernel.org/patch/11881427 >> >> Signed-off-by: Markus Reichl >> --- >> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> index e7a459fa4322..20309076dbac 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >> @@ -74,14 +74,14 @@ diy_led: led-1 { >> label = "red:diy"; >> gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; >> default-state = "off"; >> - linux,default-trigger = "mmc1"; > >> + linux,default-trigger = "mmc2"; > > remove >> }; >> >> yellow_led: led-2 { >> label = "yellow:yellow-led"; >> gpios = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>; >> default-state = "off"; >> - linux,default-trigger = "mmc0"; > >> + linux,default-trigger = "mmc1"; > > remove > >> }; >> }; >> >> > > The "mmc1" and "mmc2" options are custom values and invalid to the > automated dt check in the mainline kernel. It's already been established that the binding is at fault here. Effort should be spent on fixing *that*, not sacrificing useful and intended DT functionality in blind deference to the schema gods. Robin. > > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml > > > linux,default-trigger: > description: > This parameter, if present, is a string defining the trigger > assigned to > the LED. > $ref: /schemas/types.yaml#definitions/string > > enum: > # LED will act as a back-light, controlled by the framebuffer system > - backlight > # LED will turn on (but for leds-gpio see "default-state" > property in > # Documentation/devicetree/bindings/leds/leds-gpio.yaml) > - default-on > # LED "double" flashes at a load average based rate > - heartbeat > # LED indicates disk activity > - disk-activity > # LED indicates IDE disk activity (deprecated), in new > implementations > # use "disk-activity" > - ide-disk > # LED flashes at a fixed, configurable rate > - timer > # LED alters the brightness for the specified duration with one > software > # timer (requires "led-pattern" property) > - pattern >