From: "Ard Biesheuvel" <ardb@kernel.org>
To: "William Zhang" <william.zhang@broadcom.com>,
linux-arm-kernel@lists.infradead.org
Cc: "Song Liu" <song@kernel.org>,
linus.walleij@linaro.org, florian.fainelli@broadcom.com,
anand.gore@broadcom.com,
"Broadcom Kernel List" <bcm-kernel-feedback-list@broadcom.com>,
kursad.oney@broadcom.com,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Peter Zijlstra" <peterz@infradead.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Petr Pavlu" <petr.pavlu@suse.com>,
"Russell King" <linux@armlinux.org.uk>
Subject: Re: [PATCH v2] ARM: module: fix unwind section relocation out of range error
Date: Tue, 31 Mar 2026 16:56:22 +0200 [thread overview]
Message-ID: <bb48f874-b80f-41ef-a1a3-81f2e0a7de65@app.fastmail.com> (raw)
In-Reply-To: <CAHi4H7EC9+7yBofXE=AabeHtHFsrzOQA9kAq4of8Eu0CG2dfnA@mail.gmail.com>
Hi,
On Mon, 23 Feb 2026, at 03:30, William Zhang wrote:
> Hi,
>
> On Mon, Sep 22, 2025 at 1:24 PM William Zhang
> <william.zhang@broadcom.com> wrote:
>>
>> In an armv7 system that uses non-3G/1G split and with more than 512MB
>> physical memory, driver load may fail with following error:
>> section 29 reloc 0 sym '': relocation 42 out of range (0xc2ab9be8 ->
>> 0x7fad5998)
>>
>> This happens when relocation R_ARM_PREL31 from the unwind section
>> .ARM.extab and .ARM.exidx are allocated from the VMALLOC space while
>> .text section is from MODULES_VADDR space. It exceeds the +/-1GB
>> relocation requirement of R_ARM_PREL31 hence triggers the error.
>>
>> The fix is to mark .ARM.extab and .ARM.exidx sections as executable so
>> they can be allocated along with .text section and always meet range
>> requirement.
>>
>> Fixes: ac3b43283923 ("module: replace module_layout with module_memory")
>>
>> Co-developed-by: Ard Biesheuvel <ardb@kernel.org>
>> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>
>> ---
>>
>> Changes in v2:
>> - Fix the comment in code and commit message regarding the unwind
>> section location
>> - Add fix tag for more visibility
>>
>> arch/arm/kernel/module-plts.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/kernel/module-plts.c b/arch/arm/kernel/module-plts.c
>> index 354ce16d83cb..b5338fe59706 100644
>> --- a/arch/arm/kernel/module-plts.c
>> +++ b/arch/arm/kernel/module-plts.c
>> @@ -225,6 +225,18 @@ int module_frob_arch_sections(Elf_Ehdr *ehdr, Elf_Shdr *sechdrs,
>> mod->arch.init.plt = s;
>> else if (s->sh_type == SHT_SYMTAB)
>> syms = (Elf32_Sym *)s->sh_addr;
>> +#if defined(CONFIG_ARM_UNWIND) && !defined(CONFIG_VMSPLIT_3G)
>> + else if (s->sh_type == ELF_SECTION_UNWIND ||
>> + (strncmp(".ARM.extab", secstrings + s->sh_name, 10) == 0)) {
>> + /*
>> + * To avoid the possible relocation out of range issue for
>> + * R_ARM_PREL31, mark unwind section .ARM.extab and .ARM.exidx as
>> + * executable so they will be allocated along with .text section to
>> + * meet +/-1GB range requirement of the R_ARM_PREL31 relocation
>> + */
>> + s->sh_flags |= SHF_EXECINSTR;
>> + }
>> +#endif
>> }
>>
>> if (!mod->arch.core.plt || !mod->arch.init.plt) {
>> --
>> 2.43.7
>>
>
> Is this version okay to be accepted?
>
Please put it in Russell's patch tracker.
https://www.arm.linux.org.uk/developer/patches/
next prev parent reply other threads:[~2026-03-31 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 20:23 William Zhang
2026-02-23 2:30 ` William Zhang
2026-03-31 14:56 ` Ard Biesheuvel [this message]
2026-04-02 1:45 ` William Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb48f874-b80f-41ef-a1a3-81f2e0a7de65@app.fastmail.com \
--to=ardb@kernel.org \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bigeasy@linutronix.de \
--cc=christophe.leroy@csgroup.eu \
--cc=florian.fainelli@broadcom.com \
--cc=kursad.oney@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®