From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Yihao Han <hanyihao@vivo.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: i2s: Check before clk_unregister() not needed
Date: Fri, 10 Jun 2022 21:52:55 +0200 [thread overview]
Message-ID: <bb4ab218-3461-9afb-ecba-5c9e87f6acfc@linaro.org> (raw)
In-Reply-To: <d53ad0e2-e32d-1b46-b626-e82b44230704@wanadoo.fr>
On 10/06/2022 18:15, Christophe JAILLET wrote:
> Le 29/05/2022 à 10:06, Krzysztof Kozlowski a écrit :
>> On 27/05/2022 08:54, Yihao Han wrote:
>>> clk_unregister() already checks the clk ptr using
>>> !clk || WARN_ON_ONCE(IS_ERR(clk)) so there is no need to check it
>>> again before calling it.
>>>
>>
>> No, this explanation does not make sense. clk_unregister() warns and
>> this code is not equivalent.
>>
>>
>>
>> Best regards,
>> Krzysztof
>>
>
> Hi,
>
> Moreover, as pointed out by greg in [1] on some plateform the assertion
> in the commit description is wrong. His message is about clk_disable()
> but, IIUC, it makes sense for clk_unregister() as well. See [2] on the
> sh plateform.
>
Yes, this is true as well, although does not have the practical impact
on this driver as it uses platforms with common clock framework.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-10 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 6:54 Yihao Han
2022-05-29 8:06 ` Krzysztof Kozlowski
2022-06-10 16:15 ` Christophe JAILLET
2022-06-10 19:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb4ab218-3461-9afb-ecba-5c9e87f6acfc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hanyihao@vivo.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®