From: Shuah Khan <skhan@linuxfoundation.org>
To: Laura Nao <laura.nao@collabora.com>,
ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
shuah@kernel.org
Cc: usama.anjum@collabora.com, a.hindborg@samsung.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
kernel@collabora.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, rust-for-linux@vger.kernel.org,
kernel@valentinobst.de,
Sergio Gonzalez Collado <sergio.collado@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] kselftest: Add basic test for probing the rust sample modules
Date: Fri, 23 Feb 2024 14:48:44 -0700 [thread overview]
Message-ID: <bb4c94f5-082d-48d8-9d4c-099375603f9f@linuxfoundation.org> (raw)
In-Reply-To: <20240222162913.498197-1-laura.nao@collabora.com>
On 2/22/24 09:29, Laura Nao wrote:
> Add new basic kselftest that checks if the available rust sample modules
> can be added and removed correctly.
>
> Signed-off-by: Laura Nao <laura.nao@collabora.com>
> Reviewed-by: Sergio Gonzalez Collado <sergio.collado@gmail.com>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes in v3:
> - Removed useless KSFT_PASS, KSFT_FAIL, KSFT_SKIP constants
> - Used ktap_finished to print the results summary and handle the return code
> Changes in v2:
> - Added missing SPDX line
> - Edited test_probe_samples.sh script to use the common KTAP helpers file
> ---
> MAINTAINERS | 1 +
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/rust/Makefile | 4 +++
> .../selftests/rust/test_probe_samples.sh | 34 +++++++++++++++++++
> 4 files changed, 40 insertions(+)
> create mode 100644 tools/testing/selftests/rust/Makefile
> create mode 100755 tools/testing/selftests/rust/test_probe_samples.sh
>
Looks good to me. Don't you need a config file for this test?
Refer to config files for existing tests as a reference.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-02-23 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:29 Laura Nao
2024-02-23 21:48 ` Shuah Khan [this message]
2024-02-23 22:02 ` Shuah Khan
2024-02-26 10:21 ` Laura Nao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb4c94f5-082d-48d8-9d4c-099375603f9f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=kernel@collabora.com \
--cc=kernel@valentinobst.de \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sergio.collado@gmail.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®