From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0C9123E23C for ; Thu, 22 May 2025 12:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747915295; cv=none; b=K/f4bHaFVMJ5o1I/59Ods9N9M4e8cS0PxakphUxYc2hXXYp8Pm8A5KOw14/Z9qAiJ7K2C8s/WIb4GP114mTTrTR4YR7/cPuJ8QPeUbI+6SUT7bNR2DVFQDDN6yhabOZhdXb2WGYYEwV2zRW4wLFp48HlDHGaxSe5u55YoBCcUTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747915295; c=relaxed/simple; bh=3cZkJgLKEdh8Znywjyh4tvd6kpRmgvfQ093vzDrlQiE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Prb7V3LvCLSS16gsD/gz+sN5BZ5ns1/GTza3HyvHr0B+VErHLXwqwNr7IxjmY+agq5q5AyMBeuczThpqzZCaH5jX/G7d3njMiqqFzmt2BFNNaMaO7Xxl2x2O6CMpPMkb95TkNqJ9lv8J8mkyBygkel9FDYg+2Tks/BA5d8Xo3qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dThDvdcu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dThDvdcu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747915292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iNKHItieFldlVHFOlaztfdsZmomMboRlw+z49HMe4ok=; b=dThDvdcuBB3/HdkPufQ5SH+tTPYtTwio2yCyJUJCeUGgIwskSAmw2YKuCZdVPSzaE1MfMy mvHqZKRShr3FMUJM4HeIah3atqEVvISKejRZuPuQp0pcdP8qUOK3+dDTXCyjRa645ds2oT hYZWnYfaCknZ2/SRkKgsBs5+VboL5tQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-4vityt0CN9KWM_Z_FMqeTA-1; Thu, 22 May 2025 08:01:31 -0400 X-MC-Unique: 4vityt0CN9KWM_Z_FMqeTA-1 X-Mimecast-MFC-AGG-ID: 4vityt0CN9KWM_Z_FMqeTA_1747915290 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a360d01518so4926549f8f.2 for ; Thu, 22 May 2025 05:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747915290; x=1748520090; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iNKHItieFldlVHFOlaztfdsZmomMboRlw+z49HMe4ok=; b=Tk/Jw8qMEytc1RSpREFFfZMxKsya8G+DPfyZACvyiLA1AE/rIMoAIuqKymfpL9HyE+ 1n5XBggwXeeqmlRXaaK66iZ6JGZ23+eEiKC08nXws6zh2t4iuOS2OCWcdG4cntIgOpSl pXuNutnz9TJ064s1FV+DVCS08AIS+v14ksrozWaskfit/ySk7Vvj5q4ZlUBsvyVbXNaq AJO4zMu1gDAeFErCu2uU8TFhPpUSXGN3h6KCj/M8tWI0m8n9/oZOIP7FSbzq+fLBEX5u PKAgROze1rXYKRCHZaYKkOvwd4jQXVzz2cczejJeGQP+eSfMcnr1+w9oaGYNjS76nZn4 fCDg== X-Forwarded-Encrypted: i=1; AJvYcCWXf4zi4WFPTn0hxWO9njzlUFmZJndNOpXodoewb3N9Ae1ixG+ZT14muGpyWv0jDT44OqKA9d7Sotmch4o=@vger.kernel.org X-Gm-Message-State: AOJu0YxaoHpZJJICQUcfpZo6DvVEWxuY2/pxeHqlFj8BGgRpl5YiilMr EJ+mx7wWnhtXn87tRZkGdeg2c+219Hblxh8nLsrQBIwU1uqTXrAg/mavRwPwNUI4eL2tTTzGo5O 4sSzhX/lJsYnmSM+M5h5oPKr2WxO64FT0zQcji1rQwFTGOx2q2BcrFqVRQnP+36yjWw== X-Gm-Gg: ASbGncursaqmIu98ZQ4AKmPB00zAWuB8lJbYW9Qsemdf8SiM0D+1vmJzNuOzdjplfNL FmSP5c2sDd+Lp+Y1zMcV8HkFVfK/0CXIPdaS49hEX+DRK2aY1n3MSTudVuzKkxeixmGcXyLXzlA guEbTw0XcvT6izGkll3d8cVYEHUj+xrDrDrKITGwWUvKpgNSxulWpuw+0RsBWqA5W9Fft768ojb qsGNpv53WW3pzUIOpOncJUZrvJw/5JofvA/OOqib8DcPAIMPKzNOPjR/cN9PCayrKBMWJCHBojF VFi5dcfYqobhC7OnzaPE8UgFeHrtra7pvCjNtjfCJQ== X-Received: by 2002:a05:6000:1862:b0:3a1:f69f:3341 with SMTP id ffacd0b85a97d-3a35fe929c0mr20912555f8f.26.1747915289987; Thu, 22 May 2025 05:01:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErMUayE2jYtY0hACROYIHryKUvps/DNFcId2ztdIhvw5IaHZ+RDOk4bPfWfqVqksX/ZTFcKA== X-Received: by 2002:a05:6000:1862:b0:3a1:f69f:3341 with SMTP id ffacd0b85a97d-3a35fe929c0mr20912491f8f.26.1747915289482; Thu, 22 May 2025 05:01:29 -0700 (PDT) Received: from [192.168.3.141] (p4fe0f532.dip0.t-ipconnect.de. [79.224.245.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d230sm22458617f8f.4.2025.05.22.05.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 05:01:28 -0700 (PDT) Message-ID: Date: Thu, 22 May 2025 14:01:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 0/2] add THP_HUGE_ZERO_PAGE_ALWAYS config option To: Mike Rapoport , Pankaj Raghav Cc: Suren Baghdasaryan , Vlastimil Babka , Ryan Roberts , Michal Hocko , Thomas Gleixner , Nico Pache , Dev Jain , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Zi Yan , Dave Hansen , Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , gost.dev@samsung.com, kernel@pankajraghav.com, hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, x86@kernel.org, mcgrof@kernel.org References: <20250522090243.758943-1-p.raghav@samsung.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.05.25 13:31, Mike Rapoport wrote: > Hi Pankaj, > > On Thu, May 22, 2025 at 11:02:41AM +0200, Pankaj Raghav wrote: >> There are many places in the kernel where we need to zeroout larger >> chunks but the maximum segment we can zeroout at a time by ZERO_PAGE >> is limited by PAGE_SIZE. >> >> This concern was raised during the review of adding Large Block Size support >> to XFS[1][2]. >> >> This is especially annoying in block devices and filesystems where we >> attach multiple ZERO_PAGEs to the bio in different bvecs. With multipage >> bvec support in block layer, it is much more efficient to send out >> larger zero pages as a part of a single bvec. >> >> Some examples of places in the kernel where this could be useful: >> - blkdev_issue_zero_pages() >> - iomap_dio_zero() >> - vmalloc.c:zero_iter() >> - rxperf_process_call() >> - fscrypt_zeroout_range_inline_crypt() >> - bch2_checksum_update() >> ... >> >> We already have huge_zero_folio that is allocated on demand, and it will be >> deallocated by the shrinker if there are no users of it left. >> >> But to use huge_zero_folio, we need to pass a mm struct and the >> put_folio needs to be called in the destructor. This makes sense for >> systems that have memory constraints but for bigger servers, it does not >> matter if the PMD size is reasonable (like x86). >> >> Add a config option THP_HUGE_ZERO_PAGE_ALWAYS that will always allocate >> the huge_zero_folio, and it will never be freed. This makes using the >> huge_zero_folio without having to pass any mm struct and a call to put_folio >> in the destructor. > > I don't think this config option should be tied to THP. It's perfectly > sensible to have a configuration with HUGETLB and without THP. Such configs are getting rarer ... I assume we would then simply reuse that page from THP code if available? -- Cheers, David / dhildenb