From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbcF2KnR (ORCPT ); Wed, 29 Jun 2016 06:43:17 -0400 Received: from server.coly.li ([162.144.45.48]:52666 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbcF2KnL (ORCPT ); Wed, 29 Jun 2016 06:43:11 -0400 Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() To: Yijing Wang , axboe@fb.com, Kent Overstreet References: <1466561446-30443-1-git-send-email-wangyijing@huawei.com> Cc: Eric Wheeler , Coly Li , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org From: Coly Li Message-ID: Date: Wed, 29 Jun 2016 18:20:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466561446-30443-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 16/6/22 ÉÏÎç10:10, Yijing Wang дµÀ: > Cache_sb is not used in cache_alloc, and we have copied > sb info to cache->sb already, remove it. > > Signed-off-by: Yijing Wang > --- > drivers/md/bcache/super.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index f5dbb4e..aecaace 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj) > module_put(THIS_MODULE); > } > > -static int cache_alloc(struct cache_sb *sb, struct cache *ca) > +static int cache_alloc(struct cache *ca) > { > size_t free; > struct bucket *b; > @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page, > if (blk_queue_discard(bdev_get_queue(ca->bdev))) > ca->discard = CACHE_DISCARD(&ca->sb); > > - ret = cache_alloc(sb, ca); > + ret = cache_alloc(ca); I am not sure whether struct cache_b *sb will be used in future, I suggest to let it be for now. > if (ret != 0) > goto err; > > -- Coly Li