From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5273279DD3; Thu, 2 Oct 2025 13:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759412199; cv=pass; b=R5NAZQlQs/ZRAZGjIQ3t4wdgOq3GVT2FWCN6LhGpTVMQxnm9zlsG5Qunos6Mq6KW2xS2yXCB7j/woea29nicdS7L7psKTE2REO7SS++/L0PESiG9+v6hsr74Cf7XQxiz7hdguDhjNYqmkq2uXFmrooD8XqSDH6A+yyyLfvJ3Rgg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759412199; c=relaxed/simple; bh=ulNeW/tfFAp3cya83JiFVTYb9ntDnFuCCL0T5uhRick=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YVsNxmSSrQybwsqq5M/wiazees010EIPDcxSVFtp8wnCuFyMKGSxtB+foCYah9DLQEIT1M78Z8dg/CE7c4C8xQFv8agnxAHBgkMmiV8ZoI6FdS8L4hy16q9IxWd27TrMACANhmYXIY9hf4z6njIwQBkAkFUpgPYD3nxNThwKtDo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b=Eq3CemXE; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b="Eq3CemXE" ARC-Seal: i=1; a=rsa-sha256; t=1759412170; cv=none; d=zohomail.com; s=zohoarc; b=kqUIds6O1TiQ+WdAH9jvW7Z64Jr2CMZV/pido18x7cmJSd5Zm5552ediXflMgRoySHIoIFz7YRLb2yfD1QUWZ989nhTKFNZuk8+u/sCtGFvxTTrPm8ikKnT99U5Fq6bCIpwhFBUzTaurQ50sft0plSGf3vlwx4tzefu+XSmrs9E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759412170; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=dtSH7DMz3FFMPjGi9FtB/ixalkTfGUEAj0h124xRoog=; b=SzB44dS1gjxhZmpYJ4t+HTI6leH/9Z77F4ZLH8V7N8lsDMcwsArR7PohkJ6o4pRj307dl6A/CyoFFEGcu8YcruFIhRs9mgoUfhzvDMcGjhkOBezHNcZS8lVyycldLUf8djHgZHSrugdmLRTIG0hwcppGuogHKwsEL8+/tnwBEbI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1759412170; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=dtSH7DMz3FFMPjGi9FtB/ixalkTfGUEAj0h124xRoog=; b=Eq3CemXEpZVjh8awik3RWGFgcivKMwIT7ghfdMMVIiiR7JeKYPfwQKVflZXET/X3 xNckTwiwvc0Oj+LSPN678eKF+qkDFCKn91hA55ugIKJ21E7okQJHgIHV1exRC1k2UMK 2CbVS4P9eSmRyrADSB+K25GQNx8PnNutCoyrQ9Sw= Received: by mx.zohomail.com with SMTPS id 1759412168085227.19275215267555; Thu, 2 Oct 2025 06:36:08 -0700 (PDT) Message-ID: Date: Thu, 2 Oct 2025 16:36:02 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] media: synopsys: hdmirx: Detect broken interrupt To: Sebastian Reichel Cc: Mauro Carvalho Chehab , Hans Verkuil , jose.abreu@synopsys.com, nelson.costa@synopsys.com, shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com, kernel@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20251001175044.502393-1-dmitry.osipenko@collabora.com> From: Dmitry Osipenko Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Hi, On 10/2/25 16:18, Sebastian Reichel wrote: >> + *val = status & PHYCREG_CR_PARA_RD_DATA_MASK; >> + >> + return 0; >> +} > Do you expect this to be used in other places in the driver? In that > case there should probably be some locking, since the hardware interface > obviously cannot handle concurrency. Otherwise maybe add a comment, > that the function may not be called if concurrency is possible? Don't expect this function to be used in other places and haven't added locking on purpose to keep the code cleaner. Will add the comment. Thanks for all suggestions. -- Best regards, Dmitry