From: Hans de Goede <hdegoede@redhat.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Lee Jones <lee.jones@linaro.org>,
"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] mfd: axp20x: Fix axp288 volatile ranges
Date: Sun, 18 Dec 2016 20:18:52 +0100 [thread overview]
Message-ID: <bb6d8e9c-2683-7ea2-c4a3-a40b429dfdfe@redhat.com> (raw)
In-Reply-To: <CAGb2v64-0qhBJ5nFTtV2rEL5Bw+KrP2V1h-6wv1XQibDgzag2Q@mail.gmail.com>
Hi,
On 17-12-16 16:12, Chen-Yu Tsai wrote:
> On Sat, Dec 17, 2016 at 4:09 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> The axp288 pmic has a lot more volatile registers then we were
>> listing in axp288_volatile_ranges, fix this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
Thank you.
> FYI, if you're going to add support for the battery charger detection
> module later,
That driver is already in mainline, but like the other axp288 drivers
it needs some love to actual successfully probe and work, I've a set
of patches for ready for this, since I've been successfully testing
them the last few days I guess I might as well send them now,
so expect some patches for this soon :)
you would need to add the remaining AXP288_BC_* registers
> to the writable table.
The writeable table contains:
regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ6_STATE),
Which already includes all of the BC registers.
Regards,
Hans
next prev parent reply other threads:[~2016-12-18 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 20:09 [PATCH v3 1/2] mfd: axp20x: Add a few missing defines for AXP288 specific registers Hans de Goede
2016-12-16 20:09 ` [PATCH v3 2/2] mfd: axp20x: Fix axp288 volatile ranges Hans de Goede
2016-12-17 15:12 ` Chen-Yu Tsai
2016-12-18 19:18 ` Hans de Goede [this message]
2017-01-04 9:08 ` Lee Jones
2016-12-17 15:10 ` [PATCH v3 1/2] mfd: axp20x: Add a few missing defines for AXP288 specific registers Chen-Yu Tsai
2017-01-04 9:08 ` Lee Jones
2017-01-04 9:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6d8e9c-2683-7ea2-c4a3-a40b429dfdfe@redhat.com \
--to=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome