mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Jeremy Kerr <jk@ozlabs.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	minyard@acm.org, benjaminfair@google.com, joel@jms.id.au,
	andrew@aj.id.au
Cc: openipmi-developer@lists.sourceforge.net,
	openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v1 4/4] ipmi_bmc: bt-aspeed: port driver to IPMI BMC framework
Date: Thu, 10 Aug 2017 09:20:43 +0200	[thread overview]
Message-ID: <bb6dd1f2-ab07-a24b-6020-71aece987f4e@kaod.org> (raw)
In-Reply-To: <99a298c1-6241-f835-9587-31c526126453@ozlabs.org>

On 08/10/2017 04:31 AM, Jeremy Kerr wrote:
> Hi Brendan,
> 
>> The driver was handling interaction with userspace on its own. This
>> patch changes it to use the functionality of the ipmi_bmc framework
>> instead.
>>
>> Note that this removes the ability for the BMC to set SMS_ATN by making
>> an ioctl. If this functionality is required, it can be added back in
>> with a later patch.
> 
> As Chris has mentioned, we do use this actively at the moment, so I'd
> prefer if we could not drop the support for SMS_ATN. However, using a
> different interface should be fine, if that helps.

The ioctl is part of the kernel user API now. We should keep it.

Thanks,

C.  

  parent reply	other threads:[~2017-08-10  7:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08  3:52 [RFC v1 0/4] ipmi_bmc: framework for IPMI on BMCs Brendan Higgins
2017-08-08  3:52 ` [RFC v1 1/4] ipmi_bmc: framework for BT " Brendan Higgins
2017-08-10 13:58   ` Corey Minyard
2017-08-11  1:06     ` Brendan Higgins
2017-08-08  3:52 ` [RFC v1 2/4] ipmi_bmc: device interface to IPMI BMC framework Brendan Higgins
2017-08-08  3:53 ` [RFC v1 3/4] ipmi_bmc: bt-i2c: port driver " Brendan Higgins
2017-08-08  3:53 ` [RFC v1 4/4] ipmi_bmc: bt-aspeed: " Brendan Higgins
2017-08-10  2:31   ` Jeremy Kerr
2017-08-10  5:29     ` Brendan Higgins
2017-08-10  7:20     ` Cédric Le Goater [this message]
2017-08-14 16:03 ` [RFC v1 0/4] ipmi_bmc: framework for IPMI on BMCs Patrick Williams
2017-08-14 22:28   ` Brendan Higgins
2017-08-23  6:12     ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb6dd1f2-ab07-a24b-6020-71aece987f4e@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=benjaminfair@google.com \
    --cc=brendanhiggins@google.com \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®