From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B952C88CB2 for ; Mon, 12 Jun 2023 14:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238791AbjFLO0H (ORCPT ); Mon, 12 Jun 2023 10:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239800AbjFLOZe (ORCPT ); Mon, 12 Jun 2023 10:25:34 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 27337423C for ; Mon, 12 Jun 2023 07:23:55 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8Bx4OhcKodk_tcDAA--.6366S3; Mon, 12 Jun 2023 22:23:24 +0800 (CST) Received: from [10.20.42.43] (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxReRcKodkH2IWAA--.64643S3; Mon, 12 Jun 2023 22:23:24 +0800 (CST) Message-ID: Date: Mon, 12 Jun 2023 22:23:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v8 0/8] drm/etnaviv: add pci device driver support To: Sui Jingfeng <15330273260@189.cn>, Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter , Li Yi Cc: linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20230607105551.568639-1-15330273260@189.cn> Content-Language: en-US From: Sui Jingfeng Organization: Loongson In-Reply-To: <20230607105551.568639-1-15330273260@189.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8CxReRcKodkH2IWAA--.64643S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoW7Cw18Wr45ZFWkCw1xuw1fKrX_yoW8tr47pF 47JFyYkry8ZrW7K347AFs8JF93G3WxWF9Yk3srt3sI9w45ZFyjvryDKF45Jr9xXr1fAr42 qr1akr13WF15ArXCm3ZEXasCq-sJn29KB7ZKAUJUUUUr529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUB0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v2 6F4UJVW0owAaw2AFwI0_Jrv_JF1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0c Ia020Ex4CE44I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_ JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrw CYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j 6r4UMxCIbckI1I0E14v26r1Y6r17MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4 v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AK xVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU2G-eUUUUU Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Humble ping ? On 2023/6/7 18:55, Sui Jingfeng wrote: > From: Sui Jingfeng > > There is a Vivante GC1000 (v5037) in LS2K1000 and LS7A1000, this GPU is a > PCI device, and it has 2D and 3D cores in the same core. Thus, this patch > set is trying to add PCI device driver support to etnaviv. > > v6: > * Fix build issue on system without CONFIG_PCI enabled > v7: > * Add a separate patch for the platform driver rearrangement (Bjorn) > * Switch to runtime check if the GPU is dma coherent or not (Lucas) > * Add ETNAVIV_PARAM_GPU_COHERENT to allow userspace to query (Lucas) > * Remove etnaviv_gpu.no_clk member (Lucas) > * Various Typos and coding style fixed (Bjorn) > > v8: > * Fix typos and remove unnecessary header included (Bjorn). > * Add a dedicated function to create the virtual master platform > device. > > Sui Jingfeng (8): > drm/etnaviv: add a dedicated function to register an irq handler > drm/etnaviv: add a dedicated function to get various clocks > drm/etnaviv: add dedicated functions to create and destroy platform > devices > drm/etnaviv: add helpers for private data construction and destruction > drm/etnaviv: allow bypass component framework > drm/etnaviv: add driver support for the PCI devices > drm/etnaviv: add support for the dma coherent device > drm/etnaviv: add a dedicated function to create the virtual master > > drivers/gpu/drm/etnaviv/Kconfig | 10 + > drivers/gpu/drm/etnaviv/Makefile | 2 + > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 257 ++++++++++++++------ > drivers/gpu/drm/etnaviv/etnaviv_drv.h | 10 + > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 22 +- > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 7 +- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 168 ++++++++----- > drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 9 + > drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c | 75 ++++++ > drivers/gpu/drm/etnaviv/etnaviv_pci_drv.h | 9 + > include/uapi/drm/etnaviv_drm.h | 1 + > 11 files changed, 440 insertions(+), 130 deletions(-) > create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c > create mode 100644 drivers/gpu/drm/etnaviv/etnaviv_pci_drv.h > -- Jingfeng