From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1709C2FE05B for ; Wed, 28 Jan 2026 10:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769596017; cv=none; b=tdjs1EWFINzQEXUcTxMh63+0sn55OKxXn2gCpWTrTp845TTCfzaLa3erGL0c0NklZwfXQmfZ3/kaanv9dkFpsfsaOG/bE9MlPxiA4MFTijhOodV3AXxs0ZGMW+Yhw4OeDb+7GDtpLMUSBFlD4wVyaWly6pm6/hLEcg3P/ii0fxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769596017; c=relaxed/simple; bh=Imfj4iTgQ95yP4Qat4djxcT+jyDZxygR8oV4n1WRUwg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dIPLaNuDRCYrACrLl8xR5RhgjBUaL1c89ZE+QnkE5mF1dUG3kjiAa8MDkhICtO2OLWNbBhpj4QuS8Q2h0x5yj6W3XSZ/QMzrVSUtQmglLXLk9DRwV42F1P0KIW81UY0S+URJcpIfyLQi3L9CTN4M1oJchcxqEDX6jFhYD86p+r0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HO3mc43+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kGEfkLqK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HO3mc43+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kGEfkLqK" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S91s9k3442505 for ; Wed, 28 Jan 2026 10:26:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eD0aQjQxqkMyhCgn2ts5UcBjgfEIq6adVpGl4zx4qlc=; b=HO3mc43+Ae5ux/pM eZZBun4mrKy9eS3gUKMF7Xn856bTmIwc9v3gHS34HNpZ36mcrdyPvKXdCzfbwzkN atChW+uLBKKvkG+SKg1VgN/rf4MKzeYg4Lnvz09gZE9mSMvSauf4fl4AAibQ7xfQ EBBHPzFUmDC5fX60Kt2PJKzplCTEI7B/YDRbM8Do3zlMWmTlYAV91uyCSv1ZowNG ZXm++pIjCQT1tnDcGfUfnu3EmKL9Td/zbi+lhfw4l4sveszXWqLmqxVIfoGPvKfL oLUyO1MZvD19YvfTDJTilnCyRxYJ/gagDrWcGWwxhparwDltEpR/Rjy3iYMsP1Yf WA803w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byanah8y2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 10:26:55 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c7177d4ab4so6494285a.2 for ; Wed, 28 Jan 2026 02:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769596014; x=1770200814; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eD0aQjQxqkMyhCgn2ts5UcBjgfEIq6adVpGl4zx4qlc=; b=kGEfkLqKmD9lobcFlv48NUCPDpVeBM8nrTkueN/Tzf805Z4HTpdkh/IAzFr5d1VZy0 SQMTHrkYxlGfIl+6RBs3rfUieJ0SMWamx3bW+5AHy1QzhpTKqqrv5ADL2JkmL+vhUwkL 3IRLtMjySL7XVSz3Eed9PF9IdUw5YKFvh0a9qTx1hQOuPnWUCoiFryVfir4jz0CPjSbo xm6yxr8vUuQJjn+fSO67thdoaqBOP06Gp2Gy1n0qJErAkSlL2CciWEwn8q7B1xbpmN+r N6/Gf17eJh0s0FEqlBSP2bw7WARHiol4jB3MHdjiUMbVhxcMQLgOLp0n9gnfO9zFiXzl zl7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769596014; x=1770200814; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eD0aQjQxqkMyhCgn2ts5UcBjgfEIq6adVpGl4zx4qlc=; b=Rml7MuGK2ey6/EQKntUIwxUFGX3x1boKlf6PCl/x6XQlKKubKdfNfmAPWsNnbleUyu Vp/IjPv9E1pW6yZLsBmDC+43ljTeubQ/V2dsMgqKcHoO6hoKfH6AFM9BcHCyp++eVMIt tB81a4ocibXTAiqWe+qyblSMm0QvfgkowqgmNSYPuye5pCpVL4Z1Was3Pd7V2+ZSNMvk btwoWFF84sI4z3BHlqF3g8V7GGJiTvt7eyM+Qf1jZxq11Ds1Ym6DEDvXWS5BFN17IpLp JJV9gFc5rY8LzUKUBJGTzmEhM7Vw0nNsf9TgiVcCe4wHu5TsCb3OVn1Yz7qekTwpHlMY /RvA== X-Forwarded-Encrypted: i=1; AJvYcCUl3NLNQQRJeoh/X7m4JMq652paruVPag0tG5XH5QSw8fxsrpg0eDUdJtQ3mAOZS30UhGYiT7+fa+Y2uh8=@vger.kernel.org X-Gm-Message-State: AOJu0YzjYQaq/JeC3t49W/tMqGp5iNtfmLJJzK4apBIws2+adjMba1qJ JHBQvA1gPctmRiXssicZO0+ZBSoUOqgumlUsdizzYuqmjQ81dx2LtchM/qOGUZjIGPDVLBbAnlM YoIAWNQUMKna5vB2ysWYo10QNbeDVcLXAeP8yk2hJAC+y9UA5/FdG+fSYjvhpfo8EyYnISZK8hi I= X-Gm-Gg: AZuq6aJj3rz9tFiRvNk8rQoJjFF7zJh5sW0b78LthOtLhTYbURPME7H0nAOTxLo/NBx 91p/GWUMGMqwpkjXVkEbD5+uDsjZPw20CGo2TyCTrMuz6aXpv1tOkE4WwvptBLU1VgMp05icgS4 XIgP5c+n4hJfo9/KNXDGk+dozo35YPPjT9SsAMyCnmRbssPmS3gHNXszQZixyDGy1YWZzdFEOwM ma6Lb11/4qTZ7ZI+zwGqbuhEbpVh/iIHidokX6Tyv31G8FxAjfmODTSN0cUvtwO0pF19owLG8IH savp+SrwBxMbs47DVnzqHufFgGz9t+DObxaJYz7bJyH5V1mDDbpTcEQTh9Btl52QbS7Uhwfumc2 nMzG86B9GBI7bS06dz/RYkG3toM++M9psm97tfxZhkSvQcM33z0zK1a3Luei+/iLlG9A= X-Received: by 2002:a05:620a:4448:b0:8be:6733:92b1 with SMTP id af79cd13be357-8c714a7e659mr123179885a.0.1769596014142; Wed, 28 Jan 2026 02:26:54 -0800 (PST) X-Received: by 2002:a05:620a:4448:b0:8be:6733:92b1 with SMTP id af79cd13be357-8c714a7e659mr123177685a.0.1769596013601; Wed, 28 Jan 2026 02:26:53 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf2e0868sm107030666b.58.2026.01.28.02.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 02:26:52 -0800 (PST) Message-ID: Date: Wed, 28 Jan 2026 11:26:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] dt-bindings: clock: qcom: Add X1P42100 video clock controller To: Dmitry Baryshkov , Jagadeesh Kona Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Bryan O'Donoghue , Konrad Dybcio , Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260128-purwa-videocc-camcc-v1-0-b23de57df5ba@oss.qualcomm.com> <20260128-purwa-videocc-camcc-v1-1-b23de57df5ba@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: xGhlRfdKSDCt9uYVsju1-p7KnKY1Ctpr X-Proofpoint-ORIG-GUID: xGhlRfdKSDCt9uYVsju1-p7KnKY1Ctpr X-Authority-Analysis: v=2.4 cv=N58k1m9B c=1 sm=1 tr=0 ts=6979e46f cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6d1n1Ba-E67CpG4V2ygA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA4NSBTYWx0ZWRfXzoN23qfpwpEw bBVfcUVonSatcQSbvSGmDf6V2HuVtdt8IvRHI221jrIoKgIbop6uyRVb2AifRtYLoamMRvTYobQ HFIDUQltThWeV4IePbCxwDb2roB3BYyfWYE6bUqS5qePLJwi0ScIbo5kHfmpGCeE3aSLP9/+xRe EttFSdvpVdAZCQtqT6kxfW5ESxhFlM3m0Le1HW6ZT6FV9prQHZ6+lIg3BHUbBD7Hg0RDg+Ub0Cs ybv0KckGqXIAToNeZUyDaOSANOzcdaRX46rAS5uS80gRvqd0nmTG41vjlT4IrwSkZmWhV6q9Fjp fv7WuZa2G5pgADif5B/BSLJoAQKgrNJZL49wOpX+7EZj65RrS4idtX2lFnWKITN/h+MvUeKLSMh zLswma4j2yE0Atj2RNBh3SbYw0mqv8LLsuAN1S7spFUDdxfDQ/23BAQgkY8TKsR6PPb6pcDnc3T HzNsBo0aiek8GNgq07w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280085 On 1/27/26 9:34 PM, Dmitry Baryshkov wrote: > On Wed, Jan 28, 2026 at 12:56:32AM +0530, Jagadeesh Kona wrote: >> X1P42100 video clock controller has most clocks same as SM8650, >> but it also has few additional clocks and resets. Add device >> tree bindings for the video clock controller on Qualcomm >> X1P42100 platform by defining these additional clocks and resets >> on top of SM8650. >> >> Signed-off-by: Jagadeesh Kona >> --- >> .../bindings/clock/qcom,sm8450-videocc.yaml | 2 ++ >> include/dt-bindings/clock/qcom,x1p42100-videocc.h | 21 +++++++++++++++++++++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> index e6beebd6a36ee1ce213a816f60df8a76fa5c44d6..e8bf3fcad3fabc4f3b7e8e692c6c634d1aed9605 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml >> @@ -30,6 +30,7 @@ properties: >> - qcom,sm8650-videocc >> - qcom,sm8750-videocc >> - qcom,x1e80100-videocc >> + - qcom,x1p42100-videocc >> >> clocks: >> items: >> @@ -67,6 +68,7 @@ allOf: >> - qcom,sm8450-videocc >> - qcom,sm8550-videocc >> - qcom,sm8750-videocc >> + - qcom,x1p42100-videocc >> then: >> required: >> - required-opps >> diff --git a/include/dt-bindings/clock/qcom,x1p42100-videocc.h b/include/dt-bindings/clock/qcom,x1p42100-videocc.h >> new file mode 100644 >> index 0000000000000000000000000000000000000000..eb6c9b7264f8cbced7cfa0001903238ffa168431 >> --- /dev/null >> +++ b/include/dt-bindings/clock/qcom,x1p42100-videocc.h >> @@ -0,0 +1,21 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef _DT_BINDINGS_CLK_QCOM_VIDEO_CC_X1P42100_H >> +#define _DT_BINDINGS_CLK_QCOM_VIDEO_CC_X1P42100_H >> + >> +#include "qcom,sm8650-videocc.h" >> + >> +/* X1P42100 introduces below new clocks and resets compared to SM8650 */ > > And then someone introduces new clocks or resets into SM8650 bindings > and this gets busted. Please extend the existing header. This is funny.. $ rg sm8450-videocc.h arch/ -l arch/arm64/boot/dts/qcom/hamoa.dtsi arch/arm64/boot/dts/qcom/sm8550.dtsi arch/arm64/boot/dts/qcom/sm8450.dtsi $ rg sm8450-videocc.h drivers/ -l drivers/clk/qcom/videocc-sm8450.c hmm! :) Checking further, we have videocc-sm8550.c catering: { .compatible = "qcom,sm8550-videocc" }, { .compatible = "qcom,sm8650-videocc" }, { .compatible = "qcom,x1e80100-videocc" }, and including qcom,sm8*6*50-videocc.h BUT it doesn't end there qcom,sm8650-videocc.h starts with #include "qcom,sm8450-videocc.h" So it's quite a matryoshka.. Konrad