From: "Александра Дюпина" <adiupina@astralinux.ru>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sebastian Reichel <sre@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: dsa: add return value check of genphy_read_status()
Date: Fri, 15 Mar 2024 13:25:42 +0300 [thread overview]
Message-ID: <bb752899-dbf3-4dd2-89f0-d280488bd8bf@astralinux.ru> (raw)
In-Reply-To: <99631ba3-36f9-4eed-80d9-4a663ef46d80@lunn.ch>
Hello, Andrew!
The dsa_register_switch() function is used in various DSA
drivers (in probe function), so it is necessary to check all
possible errors. If the return value (may be an error code)
of genphy_read_status() is not checked in
dsa_shared_port_fixed_link_register_of(), a possible error
in dsa_register_switch() may be missed.
14/03/24 16:02, Andrew Lunn пишет:
> On Thu, Mar 14, 2024 at 09:30:08AM +0300, Alexandra Diupina wrote:
>> Need to check return value of genphy_read_status(),
>> because higher in the call hierarchy is the
>> dsa_register_switch() function,
>> which is used in various drivers.
> I don't understand the commit message. Why is it important to
> dsa_register_switch()?
>
> Andrew
next prev parent reply other threads:[~2024-03-15 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 6:30 Alexandra Diupina
2024-03-14 13:02 ` Andrew Lunn
2024-03-15 10:25 ` Александра Дюпина [this message]
2024-03-20 23:48 ` Florian Fainelli
2024-03-21 12:06 ` Alexandra Diupina
2024-03-27 14:08 ` [lvc-project] " Alexandra Diupina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb752899-dbf3-4dd2-89f0-d280488bd8bf@astralinux.ru \
--to=adiupina@astralinux.ru \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®