From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Russell King <linux@armlinux.org.uk>,
Karl Beldan <karl.beldan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
linux-drm <dri-devel@lists.freedesktop.org>,
linux-devicetree <devicetree@vger.kernel.org>,
Jyri Sarha <jsarha@ti.com>, David Airlie <airlied@linux.ie>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Karl Beldan <kbeldan@baylibre.com>
Subject: Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller
Date: Thu, 20 Oct 2016 13:21:47 +0300 [thread overview]
Message-ID: <bb7bac91-8eb1-fe23-ca9c-857e0fda6ecd@ti.com> (raw)
In-Reply-To: <6c6fcceb-c6f2-219d-492a-a8b38fd83093@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1351 bytes --]
On 20/10/16 13:07, Sekhar Nori wrote:
> Per me, compatible property is an ordered list precisely for the reason
> that things should continue to "work" with as closely matched driver as
> possible. So even if someone is running a kernel which does not
> recognize "ti,da850-tilcdc", it should still be able to probe the driver
> based on "ti,am33xx-tilcdc" and provide as close to full functionality
> as possible.
>
> That said, I will not insist on keeping it around if Tomi is
> uncomfortable. And having read the binding documentation accepted by
> Jyri, it actually says the compatible property should be __one of__
> "ti,am33xx-tilcdc" or "ti,da850-tilcdc".
Well, they are just not compatible as far as I know. If the LCDC on
DA850 would be identified as AM335x LCDC, and used as such, it would not
work at all. They have different registers, AM335x LCDC has registers
that do not exist on DA850.
With our driver it happens to work, because the driver looks at the IP
revision in the registers, and then decides that this IP is not AM335x
LCDC even if the dts says so. But I see that as a driver "feature",
nothing that the .dts can depend on.
Perhaps it might work the other way around, using DA850 driver on
AM335x, as DA850 LCDC is a kind of subset of AM335x LCDC. But I'm not
sure even about that.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-20 10:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 13:05 [PATCH 0/2] ARM: davinci: initial infrastructure for LCDC Bartosz Golaszewski
2016-10-05 13:05 ` [PATCH 1/2] ARM: davinci: da8xx-dt: add OF_DEV_AUXDATA entry for lcdc Bartosz Golaszewski
2016-10-05 13:05 ` [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski
2016-10-15 17:42 ` Sekhar Nori
2016-10-15 19:40 ` Bartosz Golaszewski
2016-10-17 5:56 ` Tomi Valkeinen
2016-10-17 7:12 ` Sekhar Nori
2016-10-17 7:28 ` Bartosz Golaszewski
2016-10-17 7:33 ` Tomi Valkeinen
2016-10-17 11:40 ` Laurent Pinchart
2016-10-17 12:29 ` Tomi Valkeinen
2016-10-17 12:44 ` Laurent Pinchart
2016-10-17 14:01 ` Bartosz Golaszewski
2016-10-20 10:07 ` Sekhar Nori
2016-10-20 10:21 ` Tomi Valkeinen [this message]
2016-10-20 10:29 ` Sekhar Nori
2016-10-05 15:16 ` [PATCH 0/2] ARM: davinci: initial infrastructure for LCDC Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb7bac91-8eb1-fe23-ca9c-857e0fda6ecd@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=jsarha@ti.com \
--cc=karl.beldan@gmail.com \
--cc=kbeldan@baylibre.com \
--cc=khilman@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®