From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbdBBJuF (ORCPT ); Thu, 2 Feb 2017 04:50:05 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35546 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbdBBJuD (ORCPT ); Thu, 2 Feb 2017 04:50:03 -0500 Subject: Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug To: Jon Mason , David Miller References: <1485988752-21030-1-git-send-email-jon.mason@broadcom.com> <1485988752-21030-3-git-send-email-jon.mason@broadcom.com> Cc: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hari Vyas From: Sergei Shtylyov Message-ID: Date: Thu, 2 Feb 2017 12:49:59 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1485988752-21030-3-git-send-email-jon.mason@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/2017 1:39 AM, Jon Mason wrote: > From: Hari Vyas > > ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to > bgmac_set_mac_address() but code assumed u8 *. This caused two bytes > chopping and the wrong mac address was configured. > > Signed-off-by: Hari Vyas > Signed-off-by: Jon Mason > Fixes: 4e209001b86 ("bgmac: write mac address to hardware in ndo_set_mac_address") > --- > drivers/net/ethernet/broadcom/bgmac.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c > index 0e066dc6..ea24072 100644 > --- a/drivers/net/ethernet/broadcom/bgmac.c > +++ b/drivers/net/ethernet/broadcom/bgmac.c > @@ -1222,11 +1222,15 @@ static int bgmac_set_mac_address(struct net_device *net_dev, void *addr) > { > struct bgmac *bgmac = netdev_priv(net_dev); > int ret; > + struct sockaddr *sa = addr; DaveM prefers the declarations to be arranged from longest to shortest. [...] MBR, Sergei