From: Randy Dunlap <rdunlap@infradead.org>
To: Sami Tolvanen <samitolvanen@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc: Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] x86/pci: use unsigned int in check_reserved_t
Date: Fri, 13 Nov 2020 17:19:47 -0800 [thread overview]
Message-ID: <bb843f45-1dd4-604a-dfc1-029cd9d437db@infradead.org> (raw)
In-Reply-To: <20201114002306.4166604-1-samitolvanen@google.com>
On 11/13/20 4:23 PM, Sami Tolvanen wrote:
> Use unsigned int instead of raw unsigned in check_reserved_t to follow
> the kernel's style guidelines.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> arch/x86/pci/mmconfig-shared.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index 6fa42e9c4e6f..37f31dd7005a 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -425,7 +425,7 @@ static acpi_status find_mboard_resource(acpi_handle handle, u32 lvl,
> return AE_OK;
> }
>
> -static bool is_acpi_reserved(u64 start, u64 end, unsigned not_used)
> +static bool is_acpi_reserved(u64 start, u64 end, unsigned int not_used)
> {
> struct resource mcfg_res;
>
> @@ -442,7 +442,7 @@ static bool is_acpi_reserved(u64 start, u64 end, unsigned not_used)
> return mcfg_res.flags;
> }
>
> -typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned type);
> +typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned int type);
>
> static bool __ref is_mmconf_reserved(check_reserved_t is_reserved,
> struct pci_mmcfg_region *cfg,
>
> base-commit: 9e6a39eae450b81c8b2c8cbbfbdf8218e9b40c81
>
--
~Randy
prev parent reply other threads:[~2020-11-14 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:23 Sami Tolvanen
2020-11-14 0:23 ` [PATCH v2 2/2] x86/e820: fix the function type for e820__mapped_all Sami Tolvanen
2020-11-14 1:19 ` Randy Dunlap
2020-11-14 1:19 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb843f45-1dd4-604a-dfc1-029cd9d437db@infradead.org \
--to=rdunlap@infradead.org \
--cc=bp@alien8.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®