mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Chetan Chinnadagudihundi Ravindranath (Consultant) (QUIC)" 
	<quic_cchinnad@quicinc.com>
Cc: jejb@linux.ibm.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3] scsi: ufs: Get boot device storage type from command line
Date: Mon, 1 Aug 2022 10:27:05 -0700	[thread overview]
Message-ID: <bb84d2cd-afd7-f2fb-785f-5bf6ef6f9be6@acm.org> (raw)
In-Reply-To: <d620614b-6c20-d7ed-af19-ca0accb427d6@quicinc.com>

On 7/30/22 00:54, Chetan Chinnadagudihundi Ravindranath (Consultant) 
(QUIC) wrote:
>  > why a change is being made:
> There are 2 variants of the android bootdev device. One is EMMC and 
> other is UFS. We would be not knowing the android boot storage type at 
> build time. So, we need to know the storage type at run time(bootup 
> time) by reading the  "androidboot.bootdevice=". We need to distinguish 
> between EMMC and UFS at bootup time and take appropriate action.
> 
>  > Information about why support is being added for the 
> androidboot.bootdevice parameter in the Qualcomm UFS host controller 
> driver:
> 
> We will get the "androidboot.bootdevice=" by reading cmdline
> case 1: if the boot image header version is 3
>          We get the bootdevice info by reading /proc/cmdline ( 
> __setup("androidboot.bootdevice=", get_android_boot_dev_v3);
> 
> Case 2: if the boot image header version is 4
>          We get the bootdevice info by reading /proc/bootconfig 
> (android_boot_dev_v4 = xbc_find_value("androidboot.bootdevice", &vnode))
> 
> Qualcomm UFS modules(ufs-qcom.c) calls this 
> get_storage_boot_device()(ufs-cmdline.c)   and get the bootdevice info 
> and take appropriate action. This code is yet to be upstreamed. Please 
> let me know if this info convincing.

Instead of posting the above information on the linux-scsi mailing list, 
it should be integrated in the description of the patch. Please do that 
before reposting this patch and also make sure that the code that uses 
this new kernel command line parameter is included in the same patch series.

Thanks,

Bart.

      reply	other threads:[~2022-08-01 17:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 19:00 Chetan C R
2022-07-28 19:00 ` Chetan C R
2022-07-28 20:29   ` Avri Altman
2022-07-28 21:57   ` Christoph Hellwig
2022-07-28 20:31 ` Bart Van Assche
2022-07-29 12:54   ` Chetan Chinnadagudihundi Ravindranath (Consultant) (QUIC)
2022-07-29 20:06     ` Bart Van Assche
2022-07-30  7:54       ` Chetan Chinnadagudihundi Ravindranath (Consultant) (QUIC)
2022-08-01 17:27         ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb84d2cd-afd7-f2fb-785f-5bf6ef6f9be6@acm.org \
    --to=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=quic_cchinnad@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®